Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] SwipeView not working without text attribute (UWP only) #12079

Closed
mknotzer opened this issue Sep 10, 2020 · 0 comments · Fixed by #12087
Closed

[Bug] SwipeView not working without text attribute (UWP only) #12079

mknotzer opened this issue Sep 10, 2020 · 0 comments · Fixed by #12087
Assignees
@jsuarezruiz
Labels
a/swipeview blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/1 🕐 1 in-progress This issue has an associated pull request that may resolve it! p/UWP t/bug 🐛
Projects
SwipeView vNext+1 (5.0.0) UWP Ready For Work
Milestone
5.0.0

Comments

@mknotzer
Copy link

mknotzer commented Sep 10, 2020 •
edited
Loading

Description

On UWP SwipeView inside a ListView without defining the attribute Text causes

  1. ArgumentNullException
  2. invisible but clickable ViewCells

Steps to Reproduce

<ListView> <ListView.ItemTemplate> <DataTemplate> <ViewCell> <SwipeView> <SwipeView.LeftItems> <SwipeItems> <SwipeItem IconImageSource="{StaticResource xFontAwesomeSolidTag}" /> </SwipeItems> </SwipeView.LeftItems> <Label Text="{Binding .}" /> </SwipeView> </ViewCell> </DataTemplate> </ListView.ItemTemplate> </ListView>

Basic Information

  • Version with issue:
    XF 4.8.0.1364

Screenshots

Screenshot 2020-09-10 at 10 27 30

Workaround

always define Text=""
@mknotzer mknotzer added s/unverified New report that has yet to be verified t/bug 🐛 labels Sep 10, 2020
@samhouts samhouts added this to New in Triage Sep 10, 2020
@jsuarezruiz jsuarezruiz self-assigned this Sep 11, 2020
@jsuarezruiz jsuarezruiz added this to Backlog in SwipeView via automation Sep 11, 2020
@jsuarezruiz jsuarezruiz added e/1 🕐 1 and removed s/unverified New report that has yet to be verified labels Sep 11, 2020
@jsuarezruiz jsuarezruiz moved this from New to Ready For Work in Triage Sep 11, 2020
@jsuarezruiz jsuarezruiz moved this from Backlog to In Progress in SwipeView Sep 11, 2020
@jsuarezruiz jsuarezruiz mentioned this issue Sep 11, 2020
Merged
2 tasks
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Sep 11, 2020
@samhouts samhouts added this to In Progress in vNext+1 (5.0.0) Sep 11, 2020
@mknotzer mknotzer changed the title [Bug] SwipeView crashes (ArgumentNullException) or doesn't display the rows of the ListView (UWP only) [Bug] SwipeView not working without text attribute (UWP only) Sep 13, 2020
@samhouts samhouts added this to the 5.0.0 milestone Sep 15, 2020
@samhouts samhouts added this to To do in UWP Ready For Work Sep 18, 2020
@samhouts samhouts removed this from Ready For Work in Triage Sep 18, 2020
@samhouts samhouts moved this from To do to In progress in UWP Ready For Work Sep 18, 2020
@PureWeen PureWeen added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Nov 2, 2020
UWP Ready For Work automation moved this from In progress to Done Dec 14, 2020
SwipeView automation moved this from In Progress to Done Dec 14, 2020
vNext+1 (5.0.0) automation moved this from In Progress to Done Dec 14, 2020
rmarinho pushed a commit that referenced this issue Dec 14, 2020
@jsuarezruiz
[UWP] Fix SwipeItem NRE no setting the Text (#12087) fixes #12079
11aa0fe 
* Fixed crash no settting the SwipeItem Text in UWP

* Added UITest

* Ignore for now UWP SwipeView UITest

* Updated UITest
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jsuarezruiz jsuarezruiz

Labels
a/swipeview blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/1 🕐 1 in-progress This issue has an associated pull request that may resolve it! p/UWP t/bug 🐛
Projects
SwipeView
  
Done
UWP Ready For Work
  
Done
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

[UWP] Fix SwipeItem NRE no setting the Text xamarin/Xamarin.Forms
4 participants
@PureWeen @jsuarezruiz @samhouts @mknotzer