Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[UWP] Fix SwipeItem NRE no setting the Text #12087

Merged
merged 4 commits into from
Dec 14, 2020
Merged

[UWP] Fix SwipeItem NRE no setting the Text #12087

merged 4 commits into from
Dec 14, 2020

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix SwipeItem NRE no setting the Text in UWP.

Issues Resolved

API Changes

None

Platforms Affected

  • UWP

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Launch Core Gallery and navigate to the Issue12079. Swipe to the right, if can open the SwipeView the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts added this to In Review in vNext+1 (5.0.0) Sep 11, 2020
@samhouts samhouts added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Nov 2, 2020
@PureWeen PureWeen added this to In progress in v5.0.1 via automation Nov 5, 2020
@PureWeen PureWeen removed this from In Review in vNext+1 (5.0.0) Nov 5, 2020
@rmarinho rmarinho requested review from rmarinho and removed request for samhouts November 16, 2020 10:55
@rmarinho rmarinho assigned rmarinho and unassigned samhouts Nov 16, 2020
v5.0.1 automation moved this from In progress to Reviewer approved Nov 16, 2020
@rmarinho rmarinho added this to To do in vNext+1 (5.0.0) via automation Nov 17, 2020
@rmarinho rmarinho removed this from Reviewer approved in v5.0.1 Nov 17, 2020
@rmarinho rmarinho moved this from To do to In Review in vNext+1 (5.0.0) Nov 17, 2020
@rmarinho rmarinho added this to the 5.0.0 milestone Nov 17, 2020
PureWeen
PureWeen suggested changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@PureWeen PureWeen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you add a UI Test? Should be able to just make this one a platform unit test on UWP

PureWeen
PureWeen suggested changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failing on UWP SwipeItemNoTextWindows

@PureWeen PureWeen added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Nov 25, 2020
@jsuarezruiz
Copy link
Contributor Author

The test passed on Android/iOS but is failing on UWP.
Captura de pantalla 2020-12-03 a las 20 18 33
The id is set on the control but Selenium can't find it, will take a look!

@rmarinho rmarinho removed their assignment Dec 9, 2020
@jsuarezruiz jsuarezruiz removed the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Dec 9, 2020
@rmarinho rmarinho merged commit 11aa0fe into 5.0.0 Dec 14, 2020
vNext+1 (5.0.0) automation moved this from In Review to Done Dec 14, 2020
@rmarinho rmarinho deleted the fix-12079 branch December 14, 2020 21:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@PureWeen PureWeen PureWeen approved these changes

Assignees

@PureWeen PureWeen

Labels
a/swipeview blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. p/UWP t/bug 🐛
Projects
No open projects
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

[Bug] SwipeView not working without text attribute (UWP only)
4 participants
@jsuarezruiz @rmarinho @PureWeen @samhouts