Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] IOS: Shell flyout items have a minimum height #12429

Closed
KoenMat opened this issue Oct 9, 2020 · 0 comments · Fixed by #12967
Closed

[Bug] IOS: Shell flyout items have a minimum height #12429

KoenMat opened this issue Oct 9, 2020 · 0 comments · Fixed by #12967
Labels
a/layout a/shell 🐚 t/bug 🐛
Projects
Triage Shell

Comments

@KoenMat
Copy link

KoenMat commented Oct 9, 2020

Description

In iOS, the height of flyout items adapt to the content of the itemtemplate, but there seems to be a minimum height, even if you put all items in the itemtemplate to invisible, or even with an empty template.
See screenshot below. Itemtemplate is just a label with fontsize=10 and VerticalOptions=Start

Steps to Reproduce

Expected Behavior

If all items in the template are invisible, or if the template is empty, the height in the flyout should be zero.

Actual Behavior

There is a minimum height

Basic Information

  • Version with issue: all
  • Last known good version: ?
  • IDE:
  • Platform Target Frameworks:
    • iOS: 13.3 (simulator)

Screenshots

afbeelding

Reproduction Link

Workaround
@KoenMat KoenMat added s/unverified New report that has yet to be verified t/bug 🐛 labels Oct 9, 2020
@samhouts samhouts added this to New in Triage Oct 9, 2020
@PureWeen PureWeen moved this from New to Ready For Work in Triage Oct 14, 2020
@PureWeen PureWeen added this to Backlog in Shell via automation Oct 14, 2020
@PureWeen PureWeen removed the s/unverified New report that has yet to be verified label Oct 14, 2020
@PureWeen PureWeen moved this from Backlog to To do (blockers) in Shell Oct 14, 2020
@Redth Redth moved this from Ready For Work to Needs Estimate in Triage Oct 15, 2020
@pictos pictos mentioned this issue Nov 25, 2020
Merged
2 tasks
Triage automation moved this from Needs Estimate to Closed Dec 18, 2020
Shell automation moved this from To do (blockers) to Done Dec 18, 2020
rmarinho pushed a commit that referenced this issue Dec 18, 2020
@pictos @PureWeen @jsuarezruiz
[GH-12429] Fixed extra height on Shell Flyout and fix issues with fly…
acb4af5 
…out items not updating layout (#12967) fixes #12429 fixes #12785

* Fixed extra height and added sample page

* - fix some dynamic layouts

* - fix android to resize

* - get rid of cell reuse, allow buttons inside template, let cells resize dynamically

* - Add UITests
- Fix Android Measuring

* - remove comments

* - fix UWP Measuring

* - Fix Automation Id to use Bindings on uwp

* - fix language and iOS test

* - cleanup

* - fix iOS margin issue

* - fix iOS type

Co-authored-by: shane <shneuvil@microsoft.com>
Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a/layout a/shell 🐚 t/bug 🐛
Projects
Shell
  
Done
Triage
  
Closed
Milestone
No milestone
3 participants
@PureWeen @jsuarezruiz @KoenMat