This repository has been archived by the owner on May 1, 2024. It is now read-only.
[GH-12429] Fixed extra height on Shell Flyout and fix issues with flyout items not updating layout #12967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
added
the
DO-NOT-MERGE-!!! 🛑
PureWeen
removed
the
DO-NOT-MERGE-!!! 🛑
# Conflicts: # Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems # Xamarin.Forms.Platform.Android/Renderers/ContainerView.cs
- Fix Android Measuring
PureWeen
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
PureWeen
approved these changes
Dec 16, 2020
jsuarezruiz
approved these changes
Dec 17, 2020
# Conflicts: # Xamarin.Forms.Platform.Android/Renderers/ShellViewRenderer.cs
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
On iOS if you use a custom datatemplate the height will size to whatever the height of the content you specify is. This allows for a better developer experience because the developer isn't just forced to use a min height that's impossible to overcome. Android already worked like this so this also makes the platforms consistent.
Before/After Screenshots
Before:
After:
Testing Procedure
PR Checklist