Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] TrySetPropertyValues should work with null passed for source #12643

Closed
BretJohnson opened this issue Oct 28, 2020 · 0 comments · Fixed by #12655
Closed

[Bug] TrySetPropertyValues should work with null passed for source #12643

BretJohnson opened this issue Oct 28, 2020 · 0 comments · Fixed by #12655
Assignees
@StephaneDelcroix
Labels
5.0.0-pre4 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. t/bug 🐛
Projects
Triage vNext+1 (5.0.0)
Milestone
5.0.0

Comments

@BretJohnson
Copy link

BretJohnson commented Oct 28, 2020 •
edited

As we discussed last week with Stephane, when we call TrySetPropertyValues for Hot Reload we don't have source info, so we'd like to pass null for XmlLineInfo. That will be the signal to Forms that there's no source info.

When we do that these things should happen:

  • Don't register source info on change notification.
  • Don't NRE. There are some places where it assumes XmlLineInfo is non-null.
  • Don't include source line/column in the error message.

We'd love to get this into 5.0 GA along with the other Hot Reload "blocker" changes.
@BretJohnson BretJohnson added t/bug 🐛 s/unverified New report that has yet to be verified labels Oct 28, 2020
@samhouts samhouts added this to New in Triage Oct 28, 2020
@Redth Redth added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Oct 28, 2020
@PureWeen PureWeen removed the s/unverified New report that has yet to be verified label Oct 29, 2020
@PureWeen PureWeen added this to To do in vNext+1 (5.0.0) via automation Oct 29, 2020
@PureWeen PureWeen moved this from To do to Blockers in vNext+1 (5.0.0) Oct 29, 2020
@PureWeen PureWeen moved this from New to Ready For Work in Triage Oct 29, 2020
StephaneDelcroix added a commit that referenced this issue Oct 29, 2020
@StephaneDelcroix
[X] avoid crashing on null lineinfo
573e60e 
- fixes #12643
@StephaneDelcroix StephaneDelcroix mentioned this issue Oct 29, 2020
Merged
@Redth Redth moved this from Ready For Work to Needs Estimate in Triage Oct 29, 2020
@rmarinho rmarinho moved this from Blockers to In Progress in vNext+1 (5.0.0) Oct 30, 2020
@rmarinho rmarinho added this to the 5.0.0 milestone Oct 30, 2020
Triage automation moved this from Needs Estimate to Closed Nov 2, 2020
vNext+1 (5.0.0) automation moved this from In Progress to Done Nov 2, 2020
rmarinho pushed a commit that referenced this issue Nov 2, 2020
@StephaneDelcroix
[X] avoid crashing on null lineinfo (#12655) fixes #12643
cd598e7 
- fixes #12643
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephaneDelcroix StephaneDelcroix

Labels
5.0.0-pre4 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. t/bug 🐛
Projects
No open projects
Triage
  
Closed
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

[X] avoid crashing on null lineinfo xamarin/Xamarin.Forms
5 participants
@BretJohnson @Redth @StephaneDelcroix @rmarinho @PureWeen