Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] CarouselView position resets when visibility toggled. #12848

Closed
BioTurboNick opened this issue Nov 14, 2020 · 1 comment · Fixed by #12864
Closed

[Bug] CarouselView position resets when visibility toggled. #12848

BioTurboNick opened this issue Nov 14, 2020 · 1 comment · Fixed by #12864
Assignees
@jsuarezruiz
Labels
a/carouselview e/2 🕑 2 in-progress This issue has an associated pull request that may resolve it! p/Android t/bug 🐛
Projects
Triage CarouselView

Comments

@BioTurboNick
Copy link

BioTurboNick commented Nov 14, 2020 •
edited
Loading

Description

CarouselView resets its position when its visibility is changed. It appears from the CarouselViewRenderer code that it is trying to restore the position, but for some reason is not.

Steps to Reproduce

  1. Move CarouselView to another position.
  2. Set CarouselView IsVisible=false
  3. Set CarouselView IsVisible=true
  4. Observe that the CarouselView position has been lost

Expected Behavior

CarouselView should retain its set position.

Actual Behavior

CarouselView resets to the 0 position.

Basic Information

  • Version with issue: 4.8.0.1687, 5.0.0.1558-pre-3
  • Last known good version: 4.7
  • IDE: VS 2019 16.8.1
  • Platform Target Frameworks:
    • Android: 11.0

Reproduction Link

CarouselVisibilityReset.zip
@BioTurboNick BioTurboNick added s/unverified New report that has yet to be verified t/bug 🐛 labels Nov 14, 2020
@samhouts samhouts added this to New in Triage Nov 14, 2020
@jsuarezruiz
Copy link
Contributor

On iOS works as expected.

@jsuarezruiz jsuarezruiz added e/2 🕑 2 and removed s/unverified New report that has yet to be verified labels Nov 16, 2020
@jsuarezruiz jsuarezruiz added this to Backlog in CarouselView via automation Nov 16, 2020
@jsuarezruiz jsuarezruiz moved this from New to Ready For Work in Triage Nov 16, 2020
@jsuarezruiz jsuarezruiz self-assigned this Nov 16, 2020
@jsuarezruiz jsuarezruiz mentioned this issue Nov 16, 2020
Merged
2 tasks
@jsuarezruiz jsuarezruiz added the in-progress This issue has an associated pull request that may resolve it! label Nov 17, 2020
Triage automation moved this from Ready For Work to Closed Jan 20, 2021
CarouselView automation moved this from Backlog to Done Jan 20, 2021
rmarinho pushed a commit that referenced this issue Jan 20, 2021
@jsuarezruiz
[Android] CarouselView position resets when visibility toggled (#12864)
6f9b1f6 
fixes #12848

* Fix issue with CarouselView position and visibility on Android

* Updated instructions

* Added UITest

* Fix the issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jsuarezruiz jsuarezruiz

Labels
a/carouselview e/2 🕑 2 in-progress This issue has an associated pull request that may resolve it! p/Android t/bug 🐛
Projects
CarouselView
  
Done
Triage
  
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Android] CarouselView position resets when visibility toggled xamarin/Xamarin.Forms
2 participants
@BioTurboNick @jsuarezruiz