This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android] CarouselView position resets when visibility toggled #12864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
reviewed
Nov 16, 2020
|
@rmarinho Sure, added the related UITest. |
|
Seems tests were failing on Android , can you confirm @jsuarezruiz ? |
hartez
approved these changes
Dec 9, 2020
rmarinho
suggested changes
Dec 10, 2020
|
Updated the PR merging the latest changes added to |
rmarinho
approved these changes
Jan 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix CarouselView position issue resets when visibility toggled on Android.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
Before/After Screenshots
Testing Procedure
Launch Core Gallery and navigate to the issue 12848. Swipe the Carousel to select the item numbered 2. Then, tap the Hide Button to hide the Carousel and then the Show Button to show the Carousel again. If the position of the Carousel is the same as before hiding, the test has passed.
PR Checklist