Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Elements do not revert to style after clearing local properties if style is not in root ResourceDictionary #12874

Closed
etvorun opened this issue Nov 16, 2020 · 3 comments · Fixed by #12926
Closed

[Bug] Elements do not revert to style after clearing local properties if style is not in root ResourceDictionary #12874

etvorun opened this issue Nov 16, 2020 · 3 comments · Fixed by #12926
Assignees
@StephaneDelcroix
Labels
a/style a/Xaml </> blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. external-hotreload Non-Forms bugs that affect Hot Reload t/bug 🐛
Projects
Triage vNext+1 (5.0.0)
Milestone
5.0.0

Comments

@etvorun
Copy link

etvorun commented Nov 16, 2020 •
edited by xamarin-release-manager
Loading

Description

Elements do not revert to style after clearing local properties if style is not in root ResourceDictionary.
MainPage.xaml.zip

Steps to Reproduce

  1. Create Xamarin.Froms app with UWP head
  2. Update MainPage.xaml and MainPage.xaml.cs to match attached code
  3. Build and run.
  4. Click on button.

Expected Behavior

App shows text "HorizontalOptions should revert to Center but it is Center"

Actual Behavior

App shows text "HorizontalOptions should revert to Center but it is Fill"

Basic Information

  • Version with issue: 5.0.0.1709-pre4 and 5.0.0.1558-pre3 (maybe in other builds)
  • Last known good version:
  • IDE:
  • Platform Target Frameworks:
    • iOS:
    • Android:
    • UWP:
  • Android Support Library Version:
  • Nuget Packages:
  • Affected Devices:

Screenshots

Reproduction Link

Workaround

VS bug #1247655
@etvorun etvorun added t/bug 🐛 s/unverified New report that has yet to be verified labels Nov 16, 2020
@samhouts samhouts added this to New in Triage Nov 16, 2020
@jsuarezruiz
Copy link
Contributor

Attached sample using the MainPage files:
Issue12874.zip

@jsuarezruiz jsuarezruiz moved this from New to Needs Info in Triage Nov 17, 2020
@jsuarezruiz jsuarezruiz added the s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. label Nov 17, 2020
@StephaneDelcroix StephaneDelcroix self-assigned this Nov 17, 2020
@jsuarezruiz jsuarezruiz moved this from Needs Info to Needs Estimate in Triage Nov 17, 2020
@jsuarezruiz jsuarezruiz added external-hotreload Non-Forms bugs that affect Hot Reload and removed s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. labels Nov 17, 2020
Triage automation moved this from Needs Estimate to Closed Nov 17, 2020
@etvorun
Copy link
Author

etvorun commented Nov 17, 2020

@jsuarezruiz @xamarin-release-manager
Please reactivate this bug. It blocks Hot Reload.

Triage automation moved this from Closed to New Nov 17, 2020
@jsuarezruiz jsuarezruiz moved this from New to Needs Estimate in Triage Nov 18, 2020
@jsuarezruiz jsuarezruiz removed the s/unverified New report that has yet to be verified label Nov 18, 2020
@Redth Redth added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Nov 18, 2020
@Redth Redth added this to the 5.0.0 milestone Nov 18, 2020
@Redth Redth added this to To do in vNext+1 (5.0.0) via automation Nov 18, 2020
@Redth Redth moved this from To do to Blockers in vNext+1 (5.0.0) Nov 18, 2020
@StephaneDelcroix
Copy link
Member

@etvorun I observe the same behaviour if the resource is defined at Grid or root (ContentPage) level

StephaneDelcroix added a commit that referenced this issue Nov 20, 2020
@StephaneDelcroix
[C] Keep the Style value as backup
12fa042 
When a BP is cleared, (re)apply the style value

- fixes #12874
@StephaneDelcroix StephaneDelcroix mentioned this issue Nov 20, 2020
Merged
2 tasks
StephaneDelcroix added a commit that referenced this issue Nov 20, 2020
@StephaneDelcroix
[C] Keep the Style value as backup
402d8f3 
When a BP is cleared, (re)apply the style value

- fixes #12874
StephaneDelcroix added a commit that referenced this issue Nov 20, 2020
@StephaneDelcroix
[C] Keep the Style value as backup
e1b14c1 
When a BP is cleared, (re)apply the style value

- fixes #12874
Triage automation moved this from Needs Estimate to Closed Nov 21, 2020
vNext+1 (5.0.0) automation moved this from Blockers to Done Nov 21, 2020
StephaneDelcroix added a commit that referenced this issue Nov 21, 2020
@StephaneDelcroix
[C] Keep the Style value as backup (#12926)
51f4c3b 
When a BP is cleared, (re)apply the style value

- fixes #12874
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephaneDelcroix StephaneDelcroix

Labels
a/style a/Xaml </> blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. external-hotreload Non-Forms bugs that affect Hot Reload t/bug 🐛
Projects
Triage
  
Closed
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

[C] Keep the Style value as backup xamarin/Xamarin.Forms
5 participants
@Redth @StephaneDelcroix @xamarin-release-manager @jsuarezruiz @etvorun