This repository has been archived by the owner on May 1, 2024. It is now read-only.
[C] Keep the Style value as backup #12926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
added
external-hotreload
StephaneDelcroix
force-pushed
the
fix_gh12874
branch
from
12fa042
to
402d8f3
Compare
When a BP is cleared, (re)apply the style value - fixes #12874
StephaneDelcroix
force-pushed
the
fix_gh12874
branch
from
402d8f3
to
e1b14c1
Compare
etvorun
reviewed
Nov 20, 2020
| _dispatcher = value; | ||
| } | ||
| get => _dispatcher ??= this.GetDispatcher(); | ||
| internal set => _dispatcher = value; |
There was a problem hiding this comment.
[this comment applies to CanBeSetFromStyle; GitHub does not allow comments on "unchanged" code]
nit: given that you made some unrelated improvements in this file you can do one more. Instead of 3 IF checks you can use just one:
const BindableContextAttributes trueAttr =
BindableContextAttributes.IsSetFromStyle |
BindableContextAttributes.IsDefaultValue |
BindableContextAttributes.IsDefaultValueCreated;
return ((context.Attributes & trueAttr) != 0);
etvorun
approved these changes
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When a BP is cleared, (re)apply the style value
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Before
After
Testing Procedure
PR Checklist