Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Shapes broken in Xamarin if used within NavigationPage once and navigated back #13164

Closed
maexsp opened this issue Dec 16, 2020 · 1 comment · Fixed by #13284
Closed

[Bug] Shapes broken in Xamarin if used within NavigationPage once and navigated back #13164

maexsp opened this issue Dec 16, 2020 · 1 comment · Fixed by #13284
Assignees
@jsuarezruiz
Labels
a/navigation a/shapes e/3 🕒 3 in-progress This issue has an associated pull request that may resolve it! p/Android p/iOS 🍎 t/bug 🐛
Projects
Triage

Comments

@maexsp
Copy link
Contributor

maexsp commented Dec 16, 2020

Description

Shapes are only correct rendered if shown the very first time. When navigating away from a page with shapes and re-open the page again the shapes are totally miss-rendered. See example in my repo.

Steps to Reproduce

  1. Open NavigationPage with Shapes
  2. Navigate Back
  3. Navigate again into Page with Shapes

Expected Behavior

Shapes rendered correctly when opening navigation page a 2nd time.

Actual Behavior

All shapes vertically misplaced and shrinked to 1 px.

Basic Information

  • Version with issue: XF 4.8.0.1687
  • Last known good version: unknown
  • Platform Target Frameworks:
    • iOS: 14
    • Android: 9.0
    • UWP: 19.0.3
  • Android Support Library / AndroidX Version:
  • NuGet Packages:
  • Affected Devices: Android emulator, Android Samsung phones, iPhone

Screenshots

shapesDemo

Reproduction Link

https://github.com/maexsp/XamarinFormAndroidIdiom/tree/ShapesDemo
@maexsp maexsp added s/unverified New report that has yet to be verified t/bug 🐛 labels Dec 16, 2020
@samhouts samhouts added this to New in Triage Dec 16, 2020
@jsuarezruiz jsuarezruiz self-assigned this Dec 16, 2020
@jsuarezruiz jsuarezruiz added e/3 🕒 3 and removed s/unverified New report that has yet to be verified labels Dec 16, 2020
@jsuarezruiz jsuarezruiz moved this from New to Ready For Work in Triage Dec 16, 2020
@jsuarezruiz jsuarezruiz mentioned this issue Dec 16, 2020
Closed
2 tasks
@jsuarezruiz jsuarezruiz added the in-progress This issue has an associated pull request that may resolve it! label Dec 16, 2020
@jsuarezruiz
Copy link
Contributor

The issue will be fixed by #13167

@jsuarezruiz jsuarezruiz mentioned this issue Jan 15, 2021
Merged
2 tasks
Triage automation moved this from Ready For Work to Closed Jan 15, 2021
rmarinho pushed a commit that referenced this issue Jan 15, 2021
@PureWeen @jsuarezruiz
Shapes on iOS fail to render if the bounds of the view is set prior t…
26a9f00 
…o renderer creation (#13284) fixes #12245 fixes #13225 fixes #12911 fixes #13096 fixes #13164 fixes #11924 fixes #11656 fixes #12844 fixes #12521 fixes #13407

* UI Test

* Render Shape if it has an initial size already set

* - fix ui tests

* Unified issues with the same fix.

Co-authored-by: Javier Suárez Ruiz <javiersuarezruiz@hotmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jsuarezruiz jsuarezruiz

Labels
a/navigation a/shapes e/3 🕒 3 in-progress This issue has an associated pull request that may resolve it! p/Android p/iOS 🍎 t/bug 🐛
Projects
Triage
  
Closed
Milestone
No milestone
2 participants
@jsuarezruiz @maexsp