Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android/iOS] Fix the issue with Shapes size navigating several times #13167

Closed
wants to merge 2 commits into from
Closed

[Android/iOS] Fix the issue with Shapes size navigating several times #13167

wants to merge 2 commits into from

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Dec 16, 2020 •
edited by PureWeen

Description of Change

Fix the issue with Shapes size navigating several times on Android, iOS and macOS.

NOTE: The fix (and mostly the issue) is the same as #11927

Issues Resolved

API Changes

None

Platforms Affected

  • iOS
  • Android
  • macOS

Behavioral/Visual Changes

None

Before/After Screenshots

fix13164

Testing Procedure

Launch Core Gallery and navigate to the issue 13164. Tap the Button to navigate to the details page with some Shapes. Then, navigate back, and navigate again to this page several times. If shapes are always rendered, the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jsuarezruiz jsuarezruiz mentioned this pull request Dec 16, 2020
Closed
@PureWeen PureWeen added DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. labels Jan 7, 2021
@PureWeen PureWeen added this to To do in vNext+1 (5.0.0) via automation Jan 7, 2021
@PureWeen PureWeen added this to the 5.0.0 milestone Jan 7, 2021
@samhouts samhouts added a/radiobutton 🔘 a/shell 🐚 i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often labels Jan 8, 2021
@rmarinho rmarinho moved this from To do to In Review in vNext+1 (5.0.0) Jan 12, 2021
@PureWeen PureWeen mentioned this pull request Jan 13, 2021
Merged
2 tasks
@jsuarezruiz
Copy link
Contributor Author

I'm going to close this PR because this fix is now in #13284

vNext+1 (5.0.0) automation moved this from In Review to Closed Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho Awaiting requested review from rmarinho

@PureWeen PureWeen Awaiting requested review from PureWeen

Assignees
No one assigned
Labels
a/navigation a/radiobutton 🔘 a/shapes a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often p/Android p/iOS 🍎 p/macOS t/bug 🐛
Projects
No open projects
vNext+1 (5.0.0)
Closed
Milestone
5.0.0
3 participants
@jsuarezruiz @PureWeen @samhouts