Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Enhancement] Add SearchBar platform specific for IsSpellCheckEnabled #1691

Closed
rmarinho opened this issue Jan 26, 2018 · 0 comments · Fixed by #1824
Closed

[Enhancement] Add SearchBar platform specific for IsSpellCheckEnabled #1691

rmarinho opened this issue Jan 26, 2018 · 0 comments · Fixed by #1824

Comments

@rmarinho
Copy link
Member

rmarinho commented Jan 26, 2018

Rationale

There's no way to set IsSpellCheckEnabled on the AutoSugestBox, so we need to change the control template, and also expose a new platform specific to change this property inside the control template

Implementation

We need to create a control template

Allow to enable SpellCheck for SearchBar

SearchBar.On<UWP>().IsSpellCheckEnabled();
SearchBar.On<UWP>().SetSpellCheckEnabled(true/false);
SearchBar.On<UWP>().EnableSpellCheck();
SearchBar.On<UWP>().DisableSpellCheck();

public static readonly BindableProperty IsSpellCheckEnabled Property = BindableProperty.Create("IsSpellCheckEnabled ", typeof(bool), typeof(SearchBar), false);

Expected Result

Android

None

iOS

None

UWP

Alter the default control template for AutoSuggestBox and set the property IsSpellCheckEnabled on TextBox

Implications for CSS

None

Backward Compatibility

Third party renderers may need to be updated to ensure that this functionality is supported through the new official mechanism. Further we will need to be careful to code the changes to the renderers in a careful manner to ensure that if someone is already using an effect support this feature that the effect is as best as possible not broken by our changes.

Difficulty : Easy

@lateralusX lateralusX self-assigned this Feb 5, 2018
lateralusX added a commit to lateralusX/Xamarin.Forms that referenced this issue Feb 6, 2018
lateralusX added a commit to lateralusX/Xamarin.Forms that referenced this issue Feb 6, 2018
lateralusX added a commit to lateralusX/Xamarin.Forms that referenced this issue Feb 7, 2018
@samhouts samhouts changed the title [Enhancement]Add SearchBar platform specific for IsSpellCheckEnabled [Enhancement] Add SearchBar platform specific for IsSpellCheckEnabled Apr 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants