Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Design assemblies should only target v4.5 #2216

Closed
dotMorten opened this issue Mar 31, 2018 · 8 comments
Closed

Design assemblies should only target v4.5 #2216

dotMorten opened this issue Mar 31, 2018 · 8 comments
Labels
e/2 🕑 2 help wanted We welcome community contributions to any issue, but these might be a good place to start! inactive Issue is older than 6 months and needs to be retested s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!

Comments

@dotMorten
Copy link
Contributor

dotMorten commented Mar 31, 2018

Description

The .Design assemblies are targeting .NET 4.7, but if you use Xamarin.Forms in WPF and target an older version (4.5-4.7) you'll get the following warnings:

2>------ Build started: Project: FormsTestApp.WPF, Configuration: Debug Any CPU ------
2>C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin\Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3274: The primary reference "Xamarin.Forms.Core.Design, Version=2.0.0.0, Culture=neutral, processorArchitecture=MSIL" could not be resolved because it was built against the ".NETFramework,Version=v4.7" framework. This is a higher version than the currently targeted framework ".NETFramework,Version=v4.6.1".
2>C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin\Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3274: The primary reference "Xamarin.Forms.Xaml.Design, Version=2.0.0.0, Culture=neutral, processorArchitecture=MSIL" could not be resolved because it was built against the ".NETFramework,Version=v4.7" framework. This is a higher version than the currently targeted framework ".NETFramework,Version=v4.6.1".
2>  FormsTestApp.WPF -> c:\apps\dotnet\TestApps\FormsTestApp.WPF\bin\Debug\FormsTestApp.WPF.exe
========== Build: 1 succeeded, 0 failed, 1 up-to-date, 1 skipped ==========

Steps to Reproduce

  1. Create a WPF project targeting 4.6.1
  2. Reference Xamarin.Forms.Platform.WPF.3.0.0.296286-pre2 and the dependencies which only requires 4.5.0
  3. Build, and observe the above warnings

Expected Behavior

No warning is generated.

Actual Behavior

Build warnings

Basic Information

  • Version with issue: 3.0.0.296286-pre2
  • Last known good version:
  • IDE: VS2017 (15.5.2)
  • Platform Target Frameworks:
    -net461
  • Android Support Library Version:
  • Nuget Packages:
    <PackageReference Include="Xamarin.Forms">
      <Version>3.0.0.296286-pre2</Version>
    </PackageReference>
    <PackageReference Include="Xamarin.Forms.Platform.WPF">
      <Version>3.0.0.296286-pre2</Version>
    </PackageReference>
  • Affected Devices:

Screenshots

image

@dotMorten
Copy link
Contributor Author

@jassmith jassmith closed this as completed Apr 7, 2018
@jassmith
Copy link

jassmith commented Apr 7, 2018

Sorry wrong bug, what a day Im having with that.

@jassmith jassmith reopened this Apr 7, 2018
@jassmith
Copy link

jassmith commented Apr 7, 2018

Good catch

@StephaneDelcroix
Copy link
Member

Reopening, as I reverted the PR

@samhouts samhouts added the inactive Issue is older than 6 months and needs to be retested label May 28, 2019
@samhouts samhouts added help-wanted up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! help wanted We welcome community contributions to any issue, but these might be a good place to start! and removed help-wanted labels Jun 28, 2019
@ysangkok
Copy link

So these warnings do not actually prevent using the assembly, am I right?

@samhouts
Copy link
Member

This issue doesn't seem to have had any activity in a long time. We're working on prioritizing issues and resolving them as quickly as we can. To help us get through the list, we would appreciate an update from you to let us know if this is still affecting you on the latest version of Xamarin.Forms, since it's possible that we may have resolved this as part of another related or duplicate issue. If we don't see any new activity on this issue in the next 30 days, we'll evaluate whether this issue should be closed. Thank you!

@samhouts samhouts added the s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. label Jul 13, 2020
@dotMorten
Copy link
Contributor Author

@samhouts It goes against the recommendation for .Design assemblies in VS. if Xamarin.Forms for WPF is moving to .NET Core, it might not be a big deal though?

@samhouts
Copy link
Member

Yeah, I think that since these are just warnings, and we'll want to migrate to .NET Core fully anyway, we can close this. Thanks!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e/2 🕑 2 help wanted We welcome community contributions to any issue, but these might be a good place to start! inactive Issue is older than 6 months and needs to be retested s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
None yet
Development

No branches or pull requests

5 participants