Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Spec] Shell Flyout Content Template #6293

Closed
davidortinau opened this issue May 24, 2019 · 4 comments · Fixed by #13190
Closed

[Spec] Shell Flyout Content Template #6293

davidortinau opened this issue May 24, 2019 · 4 comments · Fixed by #13190

Comments

@davidortinau
Copy link
Contributor

davidortinau commented May 24, 2019

Flyout Content Template

Allow developers to provide a template for the entire flyout.

  • Should be able to describe the whole layout
  • Developer responsible for header and footer. Any provided templates would not be applied.
<Shell.FlyoutTemplate>
    <DataTemplate>
        <Grid>
            <ContentView>
                <Label Text="My Header"/>
            </ContentView>
            
            <ListView ItemsSource="{Binding Items}">
                <ListView.ItemTemplate>
                    <DataTemplate>
                        <Grid>
                            <Image Source="{Binding Icon}"/>
                            <Label Text="{Binding Title}"/>
                        </Grid>
                    </DataTemplate>
                </ListView.ItemTemplate>
            </ListView>

            <ContentView>
                <Label Text="My Footer"/>
            </ContentView>
        </Grid>
    </DataTemplate>
</Shell.FlyoutTemplate>

API

Shell.FlyoutTemplate

Difficulty : Awesome

@PureWeen
Copy link
Contributor

PureWeen commented May 24, 2019

@davidortinau I feel like for this scenario we wouldn't use HeaderContentPresenter and FooterContentPresenter

In this scenario we would just allow users to define everything with one template.

If they want to supply their own template for the items then probably just create a
<Shell.FlyoutItemsTemplate>

It seems excessive to make them specify those presenters

@davidortinau
Copy link
Contributor Author

Yeah, I suppose that's true. Probably not worth trying to integrated in the header/footer templates if providing a template for the whole flyout.

@samhouts samhouts removed this from New in Triage May 28, 2019
@samhouts samhouts added this to Under consideration in Enhancements Jun 4, 2019
@samhouts samhouts moved this from Under consideration to Ready for Implementation in Enhancements Jun 4, 2019
@samhouts samhouts added this to the 4.3.0 milestone Jun 4, 2019
@samhouts samhouts modified the milestones: 4.3.0, 4.4.0 Aug 29, 2019
@samhouts samhouts added this to To do in v4.4.0 Nov 2, 2019
@samhouts samhouts modified the milestones: 4.4.0, 4.5.0 Nov 20, 2019
@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! labels Nov 22, 2019
@samhouts samhouts removed this from To do in v4.4.0 Nov 22, 2019
@samhouts samhouts added this to Backlog in Shell Jan 3, 2020
@samhouts samhouts moved this from Backlog to To do (blockers) in Shell Jan 3, 2020
@samhouts samhouts removed help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! labels Feb 4, 2020
@samhouts samhouts removed this from the 4.5.0 milestone Feb 11, 2020
@PureWeen PureWeen added the e/3 🕒 3 label Mar 2, 2020
@samhouts samhouts moved this from To do (blockers) to Inactive in Shell May 26, 2020
@domagojmedo
Copy link

Is there a plan to have this in any of the next versions?

@samhouts samhouts removed the inactive Issue is older than 6 months and needs to be retested label Jul 17, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 5, 2020
@samhouts samhouts added this to To do in vNext+1 (5.0.0) Aug 11, 2020
@beonami
Copy link

beonami commented Oct 28, 2020

Can every item have an effect (such as a ripple effect)?

@samhouts samhouts moved this from To do to To do 2 in vNext+1 (5.0.0) Nov 3, 2020
@PureWeen PureWeen modified the milestones: 5.0.0, .NET MAUI Nov 4, 2020
@PureWeen PureWeen added this to To do in .NET MAUI Backlog via automation Nov 4, 2020
@PureWeen PureWeen removed this from To do in vNext+1 (5.0.0) Nov 4, 2020
@samhouts samhouts removed this from To do in .NET MAUI Backlog Nov 4, 2020
Enhancements automation moved this from Ready for Implementation to Closed Dec 31, 2020
Shell automation moved this from Inactive to Done Dec 31, 2020
rmarinho pushed a commit that referenced this issue Dec 31, 2020
* Flyout Content

* - uitest

* - ios fix

* - fix ios

* - fix ios

* - fix offset

* - fix measuring issues

* - fix ScrollView Check

* - Cleanup iOS

* - remove comments

* - fix up ui test

* Remove UWP for UI Tests

* - fix merge

* - Add Flyout Items

* - fix uwp flyout items from rebinding

* - cleanup code

* Update ShellFlyoutContentRenderer.cs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Enhancements
  
Closed
Shell
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants