This repository has been archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Xamarin.Forms.Platform.Android/Renderers/ShellFlyoutTemplatedContentRenderer.cs
# Conflicts: # Xamarin.Forms.Platform.iOS/Renderers/ShellTableViewController.cs # Xamarin.Forms.Platform.iOS/Renderers/ShellTableViewSource.cs
pictos
reviewed
Dec 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't run the code yet, but I did a quick overview of the code and have these suggestions.
Xamarin.Forms.Platform.iOS/Renderers/ShellFlyoutContentManager.cs
Outdated
Show resolved
Hide resolved
Xamarin.Forms.Platform.iOS/Renderers/ShellFlyoutContentRenderer.cs
Outdated
Show resolved
Hide resolved
Xamarin.Forms.Platform.iOS/Renderers/ShellFlyoutContentRenderer.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems # Xamarin.Forms.Core/Shell/Shell.cs
# Conflicts: # Xamarin.Forms.Platform.iOS/Renderers/ShellTableViewController.cs # Xamarin.Forms.Platform.iOS/Renderers/ShellTableViewSource.cs
# Conflicts: # Xamarin.Forms.Core/Shell/Shell.cs
rmarinho
approved these changes
Dec 30, 2020
hartez
suggested changes
Dec 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering about that one Update method that's commented out. Other than that, looks fine (though I wouldn't mind seeing some of these longer methods broken up).
Xamarin.Forms.Platform.iOS/Renderers/ShellFlyoutContentRenderer.cs
Outdated
Show resolved
Hide resolved
pictos
approved these changes
Dec 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hartez
approved these changes
Dec 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a/shell 🐚
blocker
Issue blocks next stable release. Prioritize fixing and reviewing this issue.
partner/cat 😻
proposal-accepted
roadmap
t/enhancement ➕
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Only works on ios/android
This adds the ability to specify your own Content for the Flyout. If you don't want the list of FlyoutItems you can now specify Content or a ContentTemplate and it will render instead of the Flyout Items.
If you specify a Header or a Footer those will also renderer. If the content you specify is scrollable Shell will do its best to honor the Scroll Behavior for the header you've specified
Issues Resolved
API Changes
Added:
Platforms Affected
Testing Procedure
XAML Example
PR Checklist