Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug][iOS] If CollectionView in other Tab gets changed before it's displayed, it stays invisible #7700

Closed
luccasclezar opened this issue Sep 26, 2019 · 1 comment
Closed

[Bug][iOS] If CollectionView in other Tab gets changed before it's displayed, it stays invisible #7700

luccasclezar opened this issue Sep 26, 2019 · 1 comment
Assignees
@hartez
Labels
a/collectionview blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/2 🕑 2 i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often in-progress This issue has an associated pull request that may resolve it! p/iOS 🍎 t/bug 🐛
Projects
v4.3.0 Sprint 160
Milestone
4.3.0

Comments

@luccasclezar
Copy link

Description

As the title says, if you have a CollectionView in some other Tab (in a TabbedPage, of course), and change it (add or remove something) before displaying the page, the CollectionView doesn't get rendered when the page is displayed.

Steps to Reproduce

  1. Create a TabbedPage
  2. Add a CollectionView to the second tab
  3. Change the CollectionView from a Button on the first tab (add or remove an item from the ItemSource).
  4. Go to the second tab.

On the repro project:

  1. Launch
  2. Click "Add"
  3. Change to second tab.

Expected Behavior

The CollectionView appears with the modifications made on the first tab.

Actual Behavior

The CollectionView gets modified but it doesn't get rendered when the tab is displayed.

Basic Information

  • Version with issue: Everyone (including 4.4.0.1182-nightly)
  • Last known good version: None
  • Platform Target Frameworks:
    • iOS: 13.0

Screenshots

Second tab if changed before being displayed:

Simulator Screen Shot - iPhone 11 Pro Max - 2019-09-26 at 13 44 14


Second tab if displayed before being changed:

Simulator Screen Shot - iPhone 11 Pro Max - 2019-09-26 at 13 44 45

Reproduction Link

CVIssue.zip
@luccasclezar luccasclezar added s/unverified New report that has yet to be verified t/bug 🐛 labels Sep 26, 2019
@pauldipietro pauldipietro added this to New in Triage Sep 26, 2019
@luccasclezar luccasclezar changed the title [Bug][iOS] If CollectionView in other Tab gets changes before it's displayed, it stays invisible [Bug][iOS] If CollectionView in other Tab gets changed before it's displayed, it stays invisible Sep 26, 2019
@samhouts samhouts added this to Backlog in CollectionView via automation Sep 26, 2019
@luccasclezar luccasclezar mentioned this issue Sep 28, 2019
Closed
@PureWeen PureWeen added this to To do in v4.3.0 via automation Oct 5, 2019
@PureWeen PureWeen added blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. and removed s/unverified New report that has yet to be verified labels Oct 5, 2019
@PureWeen PureWeen moved this from New to Ready For Work in Triage Oct 5, 2019
@samhouts samhouts moved this from Ready For Work to Needs Estimate in Triage Oct 7, 2019
@samhouts samhouts moved this from Backlog to To do (blockers) in CollectionView Oct 8, 2019
@samhouts samhouts added this to To do in Sprint 160 via automation Oct 8, 2019
@samhouts samhouts added the e/2 🕑 2 label Oct 8, 2019
@samhouts samhouts moved this from Needs Estimate to Ready For Work in Triage Oct 8, 2019
@samhouts samhouts added this to To do in iOS Ready For Work Oct 8, 2019
@samhouts samhouts removed this from Ready For Work in Triage Oct 8, 2019
@samhouts samhouts added this to the 4.3.0 milestone Oct 10, 2019
@hartez hartez self-assigned this Oct 10, 2019
@hartez
Copy link
Contributor

hartez commented Oct 10, 2019

Fails to render on iOS 13, full-out crashes on 12 and lower.

hartez added a commit that referenced this issue Oct 11, 2019
@hartez
Prevent crash when adding item to source of CollectionView that's nev…
71f9989 
…er been displayed;

fixes #7700
@hartez hartez mentioned this issue Oct 11, 2019
Merged
2 tasks
@samhouts samhouts moved this from To do to In Progress in v4.3.0 Oct 11, 2019
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Oct 11, 2019
@samhouts samhouts moved this from To do to Ready for Review (Issues) in Sprint 160 Oct 11, 2019
@samhouts samhouts moved this from Ready for Review (Issues) to In progress in Sprint 160 Oct 13, 2019
@samhouts samhouts moved this from In progress to Ready for Review (Issues) in Sprint 160 Oct 13, 2019
@samhouts samhouts moved this from To do (blockers) to In Progress in CollectionView Oct 14, 2019
@samhouts samhouts moved this from Ready for Review (Issues) to In progress in Sprint 160 Oct 15, 2019
hartez added a commit that referenced this issue Oct 16, 2019
@hartez
Prevent crash when adding item to source of CollectionView that's nev…
d11d7bb 
…er been displayed;

fixes #7700
hartez added a commit that referenced this issue Oct 16, 2019
@hartez
Prevent crash when adding item to source of CollectionView that's nev…
831e766 
…er been displayed;

fixes #7700
@samhouts samhouts moved this from In Progress to Done in v4.3.0 Oct 16, 2019
@samhouts samhouts moved this from In progress to Done in Sprint 160 Oct 16, 2019
iOS Ready For Work automation moved this from To do to Done Oct 17, 2019
CollectionView automation moved this from In Progress to Done Oct 17, 2019
CliffAgius pushed a commit to CliffAgius/Xamarin.Forms that referenced this issue Dec 6, 2019
@hartez @CliffAgius
[iOS] Prevent crash when adding item to source of CollectionView in t…
5e4bb9a 
…ab (xamarin#7940)

* Prevent crash when adding item to source of CollectionView that's never been displayed;
fixes xamarin#7700

* Fix renaming error in UI test

* Add test and fix for adding groups offscreen

* Fix rebase error

* Remove flags

* Add instructions

* Better instructions
@samhouts samhouts added i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often and removed i/critical labels Feb 13, 2020
@samhouts samhouts removed this from Done in iOS Ready For Work May 6, 2020
@samhouts samhouts removed this from Done in CollectionView May 6, 2020
@hartez hartez mentioned this issue Feb 8, 2021
Merged
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hartez hartez

Labels
a/collectionview blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/2 🕑 2 i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often in-progress This issue has an associated pull request that may resolve it! p/iOS 🍎 t/bug 🐛
Projects
No open projects
Sprint 160
  
Done
v4.3.0
  
Done
Milestone
4.3.0
Development

No branches or pull requests
4 participants
@hartez @PureWeen @samhouts @luccasclezar