Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Entry Clear Button miss placement on android #8967

Closed
amr-moomen opened this issue Dec 19, 2019 · 0 comments · Fixed by #11814
Closed

[Bug] Entry Clear Button miss placement on android #8967

amr-moomen opened this issue Dec 19, 2019 · 0 comments · Fixed by #11814
Assignees
@memu8
Labels
a/rtl e/6 🕕 6 in-progress This issue has an associated pull request that may resolve it! p/Android t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
Android Ready For Work v5.0.1
Milestone
5.0.1

Comments

@amr-moomen
Copy link

Description

when changing the flow direction from LTR to RTL clear button should be placed on the left side of the entry on Android like IOS.

Steps to Reproduce

1- create new entry
2- change flow direction from LTR to RTL of page
3- start writing

Expected Behavior

Clear button should be placed on the left side of the entry like IOS

Actual Behavior

Clear button placed on the right side of the entry.

Basic Information

  • Version with issue: Xamarin.Forms 4.4.0.991265
  • IDE:Visual Studio 2019 Version 16.4.1
  • Platform Target Frameworks:
    • iOS: 13.2
    • Android: 9
  • Nuget Packages:
  • Affected Devices: Iphone 11 and android pixel

Screenshots

videobug

image

Reproduction Link

https://github.com/amr-moomen/EntryRemoveIconAllignment
@amr-moomen amr-moomen added s/unverified New report that has yet to be verified t/bug 🐛 labels Dec 19, 2019
@pauldipietro pauldipietro added this to New in Triage Dec 19, 2019
@rmarinho rmarinho added p/Android and removed s/unverified New report that has yet to be verified labels Dec 20, 2019
@rmarinho rmarinho moved this from New to Needs Estimate in Triage Dec 20, 2019
@samhouts samhouts moved this from Needs Estimate to Ready For Work in Triage Jan 3, 2020
@samhouts samhouts removed this from Ready For Work in Triage Jan 3, 2020
@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! and removed inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! labels Jul 17, 2020
@memu8 memu8 self-assigned this Aug 11, 2020
memu8 added a commit that referenced this issue Aug 12, 2020
@memu8
fixes #8967
4926181
memu8 added a commit that referenced this issue Aug 12, 2020
@memu8
fixes #8967
acec4f9
@samhouts samhouts added this to the 5.0.0 milestone Aug 13, 2020
@samhouts samhouts added this to To do in vNext+1 (5.0.0) Aug 14, 2020
@memu8 memu8 mentioned this issue Aug 17, 2020
Merged
2 tasks
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Aug 17, 2020
@samhouts samhouts added this to In Progress in .NET MAUI Backlog Aug 17, 2020
@samhouts samhouts moved this from To do to In progress in Android Ready For Work Aug 17, 2020
@samhouts samhouts removed this from In Progress in .NET MAUI Backlog Sep 1, 2020
@samhouts samhouts removed this from the 5.0.0 milestone Nov 2, 2020
@samhouts samhouts added this to In Progress in vNext+1 (5.0.0) Nov 3, 2020
@PureWeen PureWeen added this to the 5.0.0 milestone Nov 5, 2020
@rmarinho rmarinho removed this from the 5.0.0 milestone Nov 16, 2020
@rmarinho rmarinho added this to the 5.0.1 milestone Nov 16, 2020
@rmarinho rmarinho added this to To do in v5.0.1 via automation Nov 16, 2020
@rmarinho rmarinho removed this from In Progress in vNext+1 (5.0.0) Nov 16, 2020
@rmarinho rmarinho moved this from To do to In progress in v5.0.1 Nov 16, 2020
Android Ready For Work automation moved this from In progress to Done Dec 11, 2020
v5.0.1 automation moved this from In progress to Done Dec 11, 2020
jsuarezruiz added a commit that referenced this issue Dec 11, 2020
@memu8 @jsuarezruiz
[Android] Update the Entry clear button based on FlowDirection (#11814)
552f51a 
* changed entry clear button placement

* fixes #8967

* fixes #8967

Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@memu8 memu8

Labels
a/rtl e/6 🕕 6 in-progress This issue has an associated pull request that may resolve it! p/Android t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
Android Ready For Work
  
Done
v5.0.1
Done
Milestone
5.0.1
Development

Successfully merging a pull request may close this issue.

[Android] Update the Entry clear button based on FlowDirection xamarin/Xamarin.Forms
5 participants
@rmarinho @PureWeen @samhouts @amr-moomen @memu8