Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android] Update the Entry clear button based on FlowDirection #11814

Merged
merged 4 commits into from
Dec 11, 2020
Merged

[Android] Update the Entry clear button based on FlowDirection #11814

merged 4 commits into from
Dec 11, 2020

Conversation

memu8
Copy link
Contributor

@memu8 memu8 commented Aug 17, 2020

Description of Change

Changed the placement of the entry clear button if the flow direction is right to left

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

If the flow direction is right to left, the clear button will be left-aligned rather than right-aligned.

Before/After Screenshots

Before:
Screenshot 2020-08-17 at 11 02 21 AM

After:
Screenshot 2020-08-17 at 10 59 26 AM

Testing Procedure

Create an entry with a clear button, set the flow direction to right-to-left, and make sure the clear button is left-aligned.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jsuarezruiz jsuarezruiz changed the title Fix 8967 [Android] Update the Entry clear button based on FlowDirection Aug 17, 2020
@samhouts samhouts added this to In Review in .NET MAUI Backlog Aug 17, 2020
@samhouts samhouts added the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Aug 17, 2020
@samhouts samhouts changed the base branch from main to 5.0.0 August 31, 2020 23:36
@samhouts samhouts added retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. and removed retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. labels Aug 31, 2020
@samhouts samhouts removed this from In Review in .NET MAUI Backlog Sep 1, 2020
@samhouts samhouts added this to In Review in vNext+1 (5.0.0) Sep 1, 2020
@samhouts samhouts removed the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Nov 3, 2020
@PureWeen PureWeen added this to In progress in v5.0.1 via automation Nov 5, 2020
@PureWeen PureWeen removed this from In Review in vNext+1 (5.0.0) Nov 5, 2020
@rmarinho rmarinho moved this from In progress to Review in progress in v5.0.1 Nov 16, 2020
@jsuarezruiz
Copy link
Contributor

@memu8 Could you rebase to fix the current conflict?. Thanks!.

jsuarezruiz
jsuarezruiz approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

issue8967

v5.0.1 automation moved this from Review in progress to Reviewer approved Dec 2, 2020
@jsuarezruiz jsuarezruiz merged commit 552f51a into 5.0.0 Dec 11, 2020
v5.0.1 automation moved this from Reviewer approved to Done Dec 11, 2020
@jsuarezruiz jsuarezruiz deleted the fix-8967 branch December 11, 2020 20:24
@samhouts samhouts added this to the 5.0.0 milestone Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

@samhouts samhouts Awaiting requested review from samhouts

Assignees

@jsuarezruiz jsuarezruiz

@samhouts samhouts

Labels
a/entry a/rtl p/Android t/bug 🐛
Projects
v5.0.1
Done
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

[Bug] Entry Clear Button miss placement on android
4 participants
@memu8 @jsuarezruiz @rmarinho @samhouts