This repository has been archived by the owner on May 1, 2024. It is now read-only.
Add null check to OnActionItemClickedImpl #10075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhouts
added
p/Android
a/listview
rmarinho
approved these changes
Mar 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add a null check in OnActionItemClickedImpl. If items are in the process of being added/removed from the list, it's possible to have the context menu tap race against the actual existence of the underlying Cell.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
This one is painful to test; it's difficult to get the timing right in the original repro, and it requires tapping around in a way that's too fast for a UI test to replicate. Tooks a stab writing a platform test, but the tight coupling between the Android ListView implementation and the OS stuff for context menus makes it a very involved task.
PR Checklist