This repository has been archived by the owner on May 1, 2024. It is now read-only.
[macOS] Dark Theme support #10646
Merged
[macOS] Dark Theme support #10646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
DO-NOT-MERGE-!!! 🛑
|
I would love to try this puppy out on https://github.com/jamesmontemagno/MyStreamTimer as it is pretty small and could use some dark mode |
|
Looking really good.
|
|
Editor does not seem to have the correct text color in dark mode. |
jfversluis
force-pushed
the
macos-darktheme
branch
from
4d58d22
to
4922240
Compare
jfversluis
force-pushed
the
macos-darktheme
branch
from
4922240
to
afe8495
Compare
samhouts
added
the
retarget-branch-required
jfversluis
force-pushed
the
macos-darktheme
branch
from
afe8495
to
39a77ab
Compare
jfversluis
removed
DO-NOT-MERGE-!!! 🛑
|
Retargeted to 5.0 and removed DNM. I think I got most of the things done for this. There might be some tweaks needed here and there, but for now it seems good enough. |
|
All of the crashes were fixed in the latest commits. I am shipping an app today with the nightly builds btw |
StephaneDelcroix
approved these changes
Aug 10, 2020
|
Would this PR fix #3777 properly (instead of the workaround that was put in place there?)? |
|
@knocte yes :) |
myroot
pushed a commit
to myroot/Xamarin.Forms
that referenced
this pull request
Aug 19, 2020
* Getting there * Some hardcoded color removal * Fix cell issues * Update PageRenderer.cs fixes xamarin#8864 fixes xamarin#3777
sung-su
pushed a commit
to sung-su/Xamarin.Forms
that referenced
this pull request
Aug 20, 2020
* Getting there * Some hardcoded color removal * Fix cell issues * Update PageRenderer.cs fixes xamarin#8864 fixes xamarin#3777
sung-su
pushed a commit
to sung-su/Xamarin.Forms
that referenced
this pull request
Aug 20, 2020
* Getting there * Some hardcoded color removal * Fix cell issues * Update PageRenderer.cs fixes xamarin#8864 fixes xamarin#3777
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add necessary bits to support both native Dark Mode from 10.14 and up and the Forms xplat APIs
Issues Resolved
API Changes
public class FormsNSViewPlatforms Affected
Behavioral/Visual Changes
Some colors might be different than before when running on 10.14+. Colors where changed to use dynamic colors so the values might be different than the hard-coded ones earlier.
Before/After Screenshots
Testing Procedure
Switch your Mac to Dark Mode and run the gallery app. Everything should look easy on the eyes.
When switching while the app is running, everything should transition back and forth
PR Checklist