Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Dark mode on Mojave doesn't work right #3777

Closed
jimbobbennett opened this issue Sep 13, 2018 · 2 comments · Fixed by #5537
Closed

Dark mode on Mojave doesn't work right #3777

jimbobbennett opened this issue Sep 13, 2018 · 2 comments · Fixed by #5537
Assignees
@paymicro
Labels
e/3 🕒 3 help wanted We welcome community contributions to any issue, but these might be a good place to start! p/macOS t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!

Comments

@jimbobbennett
Copy link
Contributor

Description

When using Dark Mode on Mojave, controls are unusable due to the way they are drawn (for example no visible text on buttons).

Steps to Reproduce

  1. Create a macOS Forms app.
  2. Run it on macOS Mojave (beta)

Expected Behavior

Apps should be usable

Actual Behavior

Parts of the controls are not visible

Basic Information

  • Version with issue: 3.1.0.697729
  • Last known good version: None
  • IDE: VS for Mac
  • Platform Target Frameworks:
    • macOS
  • Affected Devices: macOS running Mojave

Screenshots

Light mode:

light

Dark Mode:

dark

Reproduction Link

https://github.com/jimbobbennett/SqueakyAppLinuxAndMac
@jvansickle
Copy link
Contributor

A workaround for this is to add "NSRequiresAquaSystemAppearance" with "Yes" in your Info.plist. This will set the application to disregard the "Dark Mode" of the OS.

@AndreiMisiukevich AndreiMisiukevich mentioned this issue Oct 24, 2018
Merged
@AndreiMisiukevich AndreiMisiukevich mentioned this issue Jan 28, 2019
Open
@samhouts samhouts added help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! labels Feb 2, 2019
knocte pushed a commit to diginex/gwallet that referenced this issue Feb 23, 2019
@winstongubantes @knocte
Frontend.XF.Mac: workaround for XF's bug on Dark theme
65c6c9d 
Workaround for xamarin/Xamarin.Forms#3777

Fixes #52
@paymicro paymicro self-assigned this Mar 13, 2019
@paymicro paymicro mentioned this issue Mar 13, 2019
Merged
3 tasks
rmarinho pushed a commit that referenced this issue Mar 18, 2019
@rmarinho
[mac] disregard the Dark mode (#5537) fixes #3777
21eb50b
@sergey-tihon
Copy link

Discussed this with @migueldeicaza today:
It may worth to think about proper support of Dark mode

adrianknight89 pushed a commit to adrianknight89/Xamarin.Forms that referenced this issue Mar 29, 2019
@adrianknight89
[mac] disregard the Dark mode (xamarin#5537) fixes xamarin#3777
230c221
codemillmatt pushed a commit to codemillmatt/Xamarin.Forms that referenced this issue Apr 19, 2019
@codemillmatt
[mac] disregard the Dark mode (xamarin#5537) fixes xamarin#3777
5208000
AxelUser pushed a commit to AxelUser/Xamarin.Forms that referenced this issue Jun 15, 2019
[mac] disregard the Dark mode (xamarin#5537) fixes xamarin#3777
43180d6
@knocte knocte mentioned this issue Aug 10, 2020
Merged
2 tasks
samhouts pushed a commit that referenced this issue Aug 17, 2020
@jfversluis
[macOS] Dark Theme support (#10646)
f303548 
* Getting there

* Some hardcoded color removal

* Fix cell issues

* Update PageRenderer.cs

fixes #8864
fixes #3777
myroot pushed a commit to myroot/Xamarin.Forms that referenced this issue Aug 19, 2020
@jfversluis @myroot
[macOS] Dark Theme support (xamarin#10646)
4571570 
* Getting there

* Some hardcoded color removal

* Fix cell issues

* Update PageRenderer.cs

fixes xamarin#8864
fixes xamarin#3777
sung-su pushed a commit to sung-su/Xamarin.Forms that referenced this issue Aug 20, 2020
@jfversluis @sung-su
[macOS] Dark Theme support (xamarin#10646)
ea17aeb 
* Getting there

* Some hardcoded color removal

* Fix cell issues

* Update PageRenderer.cs

fixes xamarin#8864
fixes xamarin#3777
sung-su pushed a commit to sung-su/Xamarin.Forms that referenced this issue Aug 20, 2020
@jfversluis @sung-su
[macOS] Dark Theme support (xamarin#10646)
e44ab75 
* Getting there

* Some hardcoded color removal

* Fix cell issues

* Update PageRenderer.cs

fixes xamarin#8864
fixes xamarin#3777
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@paymicro paymicro

Labels
e/3 🕒 3 help wanted We welcome community contributions to any issue, but these might be a good place to start! p/macOS t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Mac] disregard the Dark mode xamarin/Xamarin.Forms
6 participants
@sergey-tihon @jimbobbennett @PureWeen @jvansickle @samhouts @paymicro