This repository has been archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix Grid Starred Row/Column regressions #11903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhouts
approved these changes
Aug 24, 2020
This was referenced Aug 26, 2020
The problem has appeared for me after upgrading. I have: It worked nice, but after upgrading the elements in this Grid are less than it was. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
These changes address some regressions in starred column handling which PR #11336 introduced.
Partial starred columns (e.g., columns with a GridLength of
0.3*
) were causing columns to over-contract when fitting to a width during measurement; this caused them to squeeze to the left and not fill up the full target width. The measurements now account for columns with factors less than 1, as do the automated tests.Starred rows were not accounting for minimum row sizes when determining how far they could contract to fit into target sizes; this caused them to contract too far and not fill vertical spaces properly. The measurements now account for this, as do the automated tests.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Automated tests
PR Checklist