Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix Grid Starred Row/Column regressions #11903

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Fix Grid Starred Row/Column regressions #11903

merged 3 commits into from
Aug 24, 2020

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Aug 24, 2020

Description of Change

These changes address some regressions in starred column handling which PR #11336 introduced.

Partial starred columns (e.g., columns with a GridLength of 0.3*) were causing columns to over-contract when fitting to a width during measurement; this caused them to squeeze to the left and not fill up the full target width. The measurements now account for columns with factors less than 1, as do the automated tests.

Starred rows were not accounting for minimum row sizes when determining how far they could contract to fit into target sizes; this caused them to contract too far and not fill vertical spaces properly. The measurements now account for this, as do the automated tests.

Issues Resolved

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Automated tests

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jsuarezruiz
Copy link
Contributor

@hartez Maybe #11796 is fixed too with the changes.

@hartez
Copy link
Contributor Author

hartez commented Aug 24, 2020

@hartez Maybe #11796 is fixed too with the changes.

Might be, but they haven't provided us enough info to verify that.

@samhouts samhouts added this to the 4.8.0 milestone Aug 28, 2020
@aliyailina
Copy link

aliyailina commented Sep 11, 2020

The problem has appeared for me after upgrading. I have:
RowDefinition Height="Auto"
RowDefinition Height="Auto"
RowDefinition Height="3*"
RowDefinition Height="2*"

It worked nice, but after upgrading the elements in this Grid are less than it was.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants