Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Xamarin.Forms 5- Overlapping text if adding multiple Grid inside Grid with label having large text and also overlap if I add stack layout in between grid too. Not adding proper vertical space between two controls text. #12725

Closed
jhaprasun opened this issue Nov 3, 2020 · 8 comments · Fixed by #13085
Closed

[Bug] Xamarin.Forms 5- Overlapping text if adding multiple Grid inside Grid with label having large text and also overlap if I add stack layout in between grid too. Not adding proper vertical space between two controls text. #12725

jhaprasun opened this issue Nov 3, 2020 · 8 comments · Fixed by #13085
Assignees
@hartez
Labels
4.8.0 regression on 4.8.0 a/grid blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/3 🕒 3 i/regression in-progress This issue has an associated pull request that may resolve it! t/bug 🐛
Projects
vNext+1 (5.0.0)

Comments

@jhaprasun
Copy link

jhaprasun commented Nov 3, 2020 •
edited

Description

I installed Xamarin.Forms 5 Pre 1/2/3 and none of it helped all together. I've taken grid inside grid with label to display text. For small amount of text it doesn't have any issue. But if we have large text to display using multiple grid then it overlaps the text. And also if in between grid if I add stack layout or label then in this case text is also getting overlapped. This problem is getting replicated very easily in all the platforms(iOS,Android and UWP) and almost all the devices iPhone, iPad, Android phone, Tablet and Windows tablet in both portrait and landscape mode too.

Expected Behavior

Text should not be overlap

Actual Behavior

Text is overlapping

Basic Information

Refer description and attached sample repo project

  • Version with issue:Xamarin.Forms 5 Pre 1/2/3
  • Last known good version:Xamarin.Forms 4.5.0.356
  • IDE: Visual Studio MAC 2019
  • Platform Target Frameworks:
    • iOS: iOS 13.4
    • Android: Android 10
    • UWP: Windows 10 Enterprise version 1809
  • Nuget Packages:
    Xamarin.Forms 5 Pre 1/2/3
  • Affected Devices:
    iPhone, iPad, Android phone, Tablet, Windows tablet and Desktop

Screenshots

Screenshot-1
Screenshot-2

Reproduction Link

SampleProject.zip

Workaround

No
@jhaprasun jhaprasun added s/unverified New report that has yet to be verified t/bug 🐛 labels Nov 3, 2020
@samhouts samhouts added this to New in Triage Nov 3, 2020
@rmarinho rmarinho added 4.6.0 regression on 4.6.0 i/regression labels Nov 5, 2020
@rmarinho rmarinho moved this from New to Needs Estimate in Triage Nov 5, 2020
@rmarinho rmarinho added a/grid 4.5.0 regression on 4.5.0 labels Nov 5, 2020
@hartez
Copy link
Contributor

hartez commented Nov 5, 2020

Looks like whatever happened, it happened between 4.8.0.1269 and 4.8.0.1364.

@hartez
Copy link
Contributor

hartez commented Nov 5, 2020

Most likely the problem happened here: #11903

@hartez hartez added blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. 4.8.0 regression on 4.8.0 and removed 4.5.0 regression on 4.5.0 4.6.0 regression on 4.6.0 s/unverified New report that has yet to be verified labels Nov 5, 2020
@hartez hartez added this to To do in Other Ready For Work via automation Nov 5, 2020
@hartez hartez self-assigned this Nov 5, 2020
@hartez hartez removed this from Needs Estimate in Triage Nov 5, 2020
@hartez hartez added the e/3 🕒 3 label Nov 5, 2020
@hartez hartez added this to To do in vNext+1 (5.0.0) via automation Nov 5, 2020
@hartez hartez moved this from To do to Blockers in vNext+1 (5.0.0) Nov 5, 2020
@hartez hartez removed this from To do in Other Ready For Work Nov 5, 2020
@rmarinho
Copy link
Member

rmarinho commented Nov 6, 2020

@hartez i don't think so if you test 4.7 you see the issue.
If you test on 5.0.0 branch you see the issue.

@hasan9444
Copy link

This issue also reproducing on XF version 4.8.0.1560
any update on fixing this issue in XF 4?

@jemunk
Copy link

jemunk commented Nov 11, 2020

Upgraded to 4.8.0.1560 and now also see this issue

@hartez hartez changed the title [Bug] Xamrin.Forms 5- Overlapping text if adding multiple Grid inside Grid with label having large text and also overlap if I add stack layout in between grid too. Not adding proper vertical space between two controls text. [Bug] Xamarin.Forms 5- Overlapping text if adding multiple Grid inside Grid with label having large text and also overlap if I add stack layout in between grid too. Not adding proper vertical space between two controls text. Dec 8, 2020
hartez added a commit that referenced this issue Dec 9, 2020
@hartez
Use the largest column/row size as the star value
126d11f 
fixes #12961
fixes #12725
@hartez hartez mentioned this issue Dec 9, 2020
Merged
2 tasks
@hartez hartez added the in-progress This issue has an associated pull request that may resolve it! label Dec 9, 2020
@hartez hartez moved this from Blockers to In Review in vNext+1 (5.0.0) Dec 9, 2020
@rmarinho rmarinho moved this from In Review to In Progress in vNext+1 (5.0.0) Dec 10, 2020
hartez added a commit that referenced this issue Dec 11, 2020
@hartez
Apply maximum starred column/row size for all starred columns/rows
f43f4c0 
Fixes #12961
Fixes #12725
hartez added a commit that referenced this issue Dec 13, 2020
@hartez
Apply maximum starred column/row size for all starred columns/rows
66f1afe 
Fixes #12961
Fixes #12725
Fixes #12900
@hartez hartez closed this as completed in 30f29a3 Dec 17, 2020
vNext+1 (5.0.0) automation moved this from In Progress to Done Dec 17, 2020
@jhaprasun
Copy link
Author

jhaprasun commented Mar 25, 2021 •
edited

Hi, Issue has been fixed for iOS, UWP and macOS for all type of devices but I can see the problem still exist in Android phone and tablet both.

Version used- Xamarin.Forms v5.0.0.1931

@saimel
Copy link

saimel commented Jul 28, 2021

Hi, issue is still present in iOS. I tested in v5.0.0.1931 and v5.0.0.2083

@gauravsk1996
Copy link

Hi, Issue is still present in iOS. I tested in v5.0.0.2337.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hartez hartez

Labels
4.8.0 regression on 4.8.0 a/grid blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/3 🕒 3 i/regression in-progress This issue has an associated pull request that may resolve it! t/bug 🐛
Projects
No open projects
vNext+1 (5.0.0)
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply maximum starred column/row size for all starred columns/rows xamarin/Xamarin.Forms
7 participants
@hartez @rmarinho @jemunk @gauravsk1996 @saimel @jhaprasun @hasan9444