This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] Avoid SwipeBehaviorOnInvoked="RemainOpen" triggers event twice #11904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
suggested changes
Aug 24, 2020
|
|
||
| } | ||
|
|
||
| #if APP |
There was a problem hiding this comment.
Can we automate SwipeItems? If so, this test should be automated. If not, we need some instructions for whoever is manually running it (e.g., "Open the Swipeitem; if the alert displays twice, this test has failed".)
samhouts
added
retarget-branch-required
jsuarezruiz
force-pushed
the
fix-11643
branch
from
f8e2d24
to
942d59f
Compare
hartez
approved these changes
Oct 26, 2020
rmarinho
approved these changes
Oct 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Avoid SwipeBehaviorOnInvoked="RemainOpen" triggers event twice on iOS.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Testing Procedure
Launch Core Gallery and navigate to the issue 11875. Swipe and tap the SwipeItem. If the event fires only once, the test has passed.
PR Checklist