This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Build] Remove VS2017 and old XCODE support, move Flex to core project #11972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
added
the
t/housekeeping ♻︎
samhouts
approved these changes
Aug 31, 2020
PureWeen
reviewed
Sep 1, 2020
| @@ -10,7 +10,7 @@ | |||
| <RootNamespace>Embedding.iOS</RootNamespace> | |||
| <IPhoneResourcePrefix>Resources</IPhoneResourcePrefix> | |||
| <AssemblyName>Embedding.iOS</AssemblyName> | |||
| <DefineConstants Condition="'$(Use2017)' != 'true'">__XCODE11__;$(DefineConstants);</DefineConstants> | |||
| <DefineConstants>__XCODE11__;$(DefineConstants);</DefineConstants> | |||
There was a problem hiding this comment.
can we remove this and all related IF DEFS?
rmarinho
changed the title
PureWeen
approved these changes
Sep 1, 2020
samhouts
added
breaking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Builds on top of #11971
Remove VS2017 support for 5.0.0 and MAUI
Remove old XCODE support
Move Xamarin.Flex to the core project
part of #11857
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist