This repository has been archived by the owner on May 1, 2024. It is now read-only.
Make Frames with Labels work in ListViews again #11976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
added
4.4.0
rmarinho
approved these changes
Sep 7, 2020
|
Fix seems good but test is failing on API19 |
StephaneDelcroix
approved these changes
Sep 8, 2020
samhouts
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
PR #8032 broke Labels inside of Frames in ListView ViewCells - this can be seen by running UI test for issue #1415; the ListView items should have text in them, and after #8032 they do not.
These changes restore the functionality used in the #1415 test while preserving the corner radius clipping changes from #8032.
Issues Resolved
Text not displaying inside of Frames used as the DataTemplate for a ListView's ViewCells.
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Automated test for #7823 (should still pass); also make sure to run #1415 (sadly, manual) and verify that text displays in the ListView items.
PR Checklist