Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Core] Remove Expander #12005

Merged
merged 6 commits into from
Sep 9, 2020
Merged

[Core] Remove Expander #12005

merged 6 commits into from
Sep 9, 2020

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Sep 2, 2020 •
edited by samhouts

Description of Change

Expander moved to the XTC you can check the PR here

Issues Resolved

API Changes

Removed:

  • Expander

None

Platforms Affected

  • Core/XAML (all platforms)

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@rmarinho
Copy link
Member Author

rmarinho commented Sep 2, 2020

@samhouts @PureWeen do we want to throw if someone uses the Flag ? or just remove the flag

@rmarinho rmarinho changed the title [Core] Remove expander [Core] Remove Expander Sep 2, 2020
@samhouts samhouts added this to In Review in vNext+1 (5.0.0) Sep 2, 2020
@samhouts
Copy link
Member

samhouts commented Sep 2, 2020

Just remove :)

@rmarinho rmarinho merged commit d2e6cbb into 5.0.0 Sep 9, 2020
vNext+1 (5.0.0) automation moved this from In Review to Done Sep 9, 2020
@rmarinho rmarinho deleted the remove-expandar branch September 9, 2020 17:03
@samhouts samhouts added this to Done in Sprint 176 Sep 9, 2020
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Sep 9, 2020
@samhouts samhouts added this to the 5.0.0 milestone Sep 19, 2020
@samhouts samhouts added breaking Changes behavior or appearance a/expander API-change Heads-up to reviewers that this PR may contain an API change deprecation Public API has been deprecated m/high impact ⬛ proposal-open labels Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephaneDelcroix StephaneDelcroix StephaneDelcroix approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

Assignees

@StephaneDelcroix StephaneDelcroix

@jsuarezruiz jsuarezruiz

Labels
a/expander a/Xaml </> API-change Heads-up to reviewers that this PR may contain an API change approved Has two approvals, no pending reviews, and no changes requested breaking Changes behavior or appearance ControlGallery deprecation Public API has been deprecated m/high impact ⬛ proposal-open roadmap t/enhancement ➕
Projects
No open projects
Sprint 176
  
Done
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

[Spec] Major Breaking Changes Proposed for Xamarin.Forms 5.0
4 participants
@rmarinho @samhouts @StephaneDelcroix @jsuarezruiz