Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Rename MDP to Flyoutpage #12073

Merged
merged 12 commits into from
Sep 17, 2020
Merged

Rename MDP to Flyoutpage #12073

merged 12 commits into from
Sep 17, 2020

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Sep 10, 2020

Description of Change

Rename MDP to Flyoutpage

API Changes

Added:

	public class FlyoutPage
	{
		Page Flyout,
                Page Detail
	}
	public enum FlyoutLayoutBehavior
	{
		Default = 0,
		SplitOnLandscape = 1,
		Split = 2,
		Popover = 3,
		SplitOnPortrait = 4
	}

Platforms Affected

  • Core/XAML (all platforms)
  • iOS
  • Android
  • UWP

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Sep 10, 2020
@jsuarezruiz
Copy link
Contributor

The build is failing in the Tizen project "'IMasterDetailPageController' is obsolete: 'FLYOUTPAGE'".

Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are pending changes mostly in the issues project. What will happen to all the tests where TestMasterDetailPage is used? Will be changed to use FlyoutPage?

@PureWeen
Copy link
Contributor Author

@jsuarezruiz eventually yes but I wanted to keep the CG setup for MDP so the UI tests can validate that it still works

@PureWeen PureWeen removed the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Sep 16, 2020
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests not related

@PureWeen PureWeen added the breaking Changes behavior or appearance label Sep 17, 2020
@rmarinho rmarinho merged commit 0c95d09 into 5.0.0 Sep 17, 2020
@rmarinho rmarinho deleted the mdp_to_flyout branch September 17, 2020 22:47
vNext+1 (5.0.0) automation moved this from In Progress to Done Sep 17, 2020
@samhouts samhouts added this to Done in Sprint 176 Sep 18, 2020
@samhouts samhouts added this to the 5.0.0 milestone Sep 19, 2020
@samhouts samhouts added API-change Heads-up to reviewers that this PR may contain an API change deprecation Public API has been deprecated m/high impact ⬛ proposal-open t/enhancement ➕ labels Sep 23, 2020
@Tommigun1980
Copy link

This change broke the NuGets in my project, #12224, so I had to revert back to Xamarin.Forms 4 as it may take months for plugins to get updated, in case they ever will.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Spec] Major Breaking Changes Proposed for Xamarin.Forms 5.0
5 participants