Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

MultiBinding StringFormat with MultiValueConverter #12100

Merged
merged 2 commits into from
Oct 15, 2020
Merged

MultiBinding StringFormat with MultiValueConverter #12100

merged 2 commits into from
Oct 15, 2020

Conversation

YZahringer
Copy link
Contributor

Description of Change

Fix MultiBinding.StringFormat to use result of MultiValueConverter.

Issues Resolved

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

Use MultiValueConverter result for StringFormat.

Before/After Screenshots

Not applicable

Testing Procedure

Unit test MultiBindingTests.TestConverterWithStringFormat added.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@YZahringer YZahringer changed the title TryFormat with result of MultiValueConverter MultiBinding StringFormat with MultiValueConverter Sep 12, 2020
@StephaneDelcroix
Copy link
Member

@YZahringer could you please rebase your branch on top of 5.0.0 ? thx

@StephaneDelcroix StephaneDelcroix merged commit cbcb0f6 into xamarin:5.0.0 Oct 15, 2020
@samhouts samhouts added this to the 5.0.0 milestone Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] MultiBinding StringFormat with MultiValueConverter
5 participants