This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] Fix crash with TimePicker on iOS14 #12158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jsuarezruiz
approved these changes
Sep 18, 2020
samhouts
approved these changes
Sep 18, 2020
samhouts
added
p/iOS 🍎
a/timepicker
i/high
samhouts
added
the
approved
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix the TimePicker crash on iOS14 by forcing the PreferredDatePickerStyle to UIDatePickerStyle.Wheels.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Use Xcode12, iOS14 device, and Xamarin.iOS for IOS14.
Go to issue 11943, click on the date , make sure the time picker wheels appear and you able to select a time.
make sure it also works on iOS13
PR Checklist