Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xaml] still load Xaml from old assemblies... #1224

Merged
merged 1 commit into from Oct 24, 2017

Conversation

@StephaneDelcroix
Copy link
Member

StephaneDelcroix commented Oct 24, 2017

Description of Change

if the project references an assembly that was generated using a Xamlg version not creating XamlResourceId, we need to fallback to the old logic to load xaml controls from those assemblies.

Bugs Fixed

  • not reported yet

API Changes

/

Behavioral Changes

/

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@@ -154,7 +154,7 @@ static string GetXamlForType(Type type)
var assembly = typeInfo.Assembly;
var resourceId = typeInfo.GetCustomAttribute<XamlResourceIdAttribute>()?.ResourceId;
if (resourceId == null)
return null;
return LegacyGetXamlForType(type);

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Oct 24, 2017

Author Member

this were I should add a Task.Delay(1000); to force new adoption

@StephaneDelcroix StephaneDelcroix merged commit 932b543 into master Oct 24, 2017
2 checks passed
2 checks passed
VSTS: Xamarin Forms Windows 1083418 Succeeded
Details
VSTS: Xamarin Forms Windows (PR Builds) Started PR process 1074648
Details
@StephaneDelcroix StephaneDelcroix deleted the restoreXamlLoading branch Oct 24, 2017
@samhouts samhouts added this to the 3.0.0 milestone May 5, 2018
@samhouts samhouts modified the milestones: 3.0.0, 2.5.0 Aug 23, 2019
@samhouts samhouts modified the milestones: 3.0.0, 2.5.0 Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.