This repository has been archived by the owner on May 1, 2024. It is now read-only.
Added Shell parameters #12465
Closed
Added Shell parameters #12465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pictos
commented
Oct 13, 2020
PureWeen
suggested changes
Oct 17, 2020
|
this removes the ability of serializing navigation Uris to strings (for, e.g., deep linking). I'd be more confortable if this was a Dictionary<string,string> |
that's a lame excuse for obsoleting :) |
|
Apologies on this one @pictos I gave you premature guidance on this one and as it currently stands we can't really take in an API change like this pre .NET MAUI |
PureWeen
added
the
blocker
pictos
force-pushed
the
ShellParameters
branch
from
255d6ea
to
3974ae8
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
… of CollectionView (xamarin#12823) fixes xamarin#9282 * Handle selected background color updates after cell is added as child of CollectionView Fixes xamarin#9282 * Fix formatting
) * [iOS] Fix when removing current last Item on CarouselView * [Uitests] Try fix test for 12574 * [iOS] Fix scroll when removing item on CarouselView * [iOS] Use CollectionView.PerformBatchUpdates to scroll to item after CollectionView reloads it's items * [iOS] Set Reload next to Scroll to better understand the logic between the 2 * [iOS] Fix for reload items and wait for iOS12 and iOS11 * Provide pre and post update events for CarouselView to do its bookkeeping * Remove animation after item removal * [Controls] Fix sample 12574 * [UITests] Enable test * Remove performBatchUpdates calls to prevent data disparity; * Remove async stuff from ObservableGroupedSource * Fix reload race condition with deletion/insertion of groups * Reset current item and position when ItemsSource resets * Update ObservableSource count before invoking Carousel's changed handler; Reset position/current item on ItemsSource update Don't update position until drag is released * Clean up unnecessary ReloadRequired stuff * Handle UICollectionView internal accounting edge cases Co-authored-by: E.Z. Hart <hartez@gmail.com>
…amarin#11679) * added constructor actionsheet * added flow direction to action sheets on Android * added flow direction to alerts on Android * added Android alert dialog flow direction * UWP alert/actionsheet flow direction * add alert dialog flow direction * added flow direction to UWP alert and actionsheets * fixes xamarin#2448 * fixes xamarin#2448 * fixes xamarin#2448 * fixes xamarin#2448 * fixes xamarin#2448 * fixes xamarin#2448 * fixes xamarin#2448 * Fix rebase errors * - fix rebase Co-authored-by: E.Z. Hart <hartez@gmail.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…t selecting visible content (xamarin#13046) fixes xamarin#12642 * Convert to Property Animators * - uitests * Update ShellSectionRootRenderer.cs * - fix nre
…4720) (xamarin#12509) * To address issue xamarin#4720: Add option for custom renderers to control the execution mode of the WebView control This is 'opt-in' as by default this commit will not change behavior of existing applciations. to opt-in, people would need to set the ExecutionMode property in the constructor of their custom WebViewRenderer, like: public class MyWebViewRenderer : WebViewRenderer { public MyWebViewRenderer() { ExecutionMode = Windows.UI.Xaml.Controls.WebViewExecutionMode.SeparateProcess; } } When set as 'SeparateProcess', the memory allocated by the WebView itself is all handled in a sub-process, which ensures the main process never crashes from running out of memory here from doing things like opening and closing youtube every 5 seconds. This behavior will likely crash when the WebView is in-process due to the huge amounts of memory that is required by that website. * tabs not spaces * TemplatedItemsList: Ensure items are unhooked correctly when removing them, whether as individual removals or list resets. Without this, the native cells do not actually get removed. CellTableViewCell: use event PropertyChangedEventHandler instead of action (seems more standard) TextCellRenderer: Correct the event delegate hookup ListViewRenderer: Actually re-use the UITableViewCell when creating header sections, otherwise we endlessly create new ones, leaving the old ones alive through event handlers * Revert "TemplatedItemsList: Ensure items are unhooked correctly when removing them, whether as individual removals or list resets. Without this, the native cells do not actually get removed." This reverts commit 7da9ffb. * Make the custom renderer only apply to the test for this issue, as it seems the SeparateProcess affects access to cookies, breaking other tests * Move additional classes inside test class to decrease namespace cluttering. * - cleanup and rebase * - add instructions * - move WebViewExecutionMode to platform specific * - fix up UI Test * - clean up tests * - fix tabs * - fix formatting * - fix teardown call * - fix async ui test quirk on uwp Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
…ixes xamarin#12685 fixes xamarin#13020 * Added repro sample * Fixed the issue * Update Issue11050.xaml.cs * Updated issue 10626. Replaced Color by Brush. * Fixed build error * Fixed build error * Added Issue12685 test * Changes in text format * Fix rebase error Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@gmail.com> Co-authored-by: Rui Marinho <me@ruimarinho.net>
…amarin#12750 * Fixed wrong SwipeView Layout in Android * Fixed build error * - small fixes Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
When the activity is destroyed an event remain attached, if the application is a singleton this cause a memory leak of the activity.
pictos
force-pushed
the
ShellParameters
branch
from
6f5570f
to
0a900a9
Compare
… ShellParameters # Conflicts: # Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue10623.cs # Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue12642.cs # Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue12750.xaml.cs # Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue4720.cs # Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems # Xamarin.Forms.Core.UITests.Shared/Tests/CarouselViewUITests.cs # Xamarin.Forms.Core/Shell/Shell.cs # Xamarin.Forms.Core/Shell/ShellItem.cs # Xamarin.Forms.Platform.Android/Renderers/SwipeViewRenderer.cs # Xamarin.Forms.Platform.iOS.UnitTests/ObservableItemsSourceTests.cs # Xamarin.Forms.Platform.iOS/CollectionView/IndexPathHelpers.cs # Xamarin.Forms.Platform.iOS/CollectionView/ItemsViewController.cs # Xamarin.Forms.Platform.iOS/CollectionView/ObservableItemsSource.cs # Xamarin.Forms.Platform.iOS/Renderers/SwipeViewRenderer.cs
pictos
commented
Dec 30, 2020
| @@ -495,6 +495,26 @@ public Task GoToAsync(ShellNavigationState state, bool animate) | |||
| return _navigationManager.GoToAsync(state, animate, false); | |||
| } | |||
|
|
|||
| internal Task GoToAsync(ShellNavigationState state, ShellRouteParameters parameters) | |||
There was a problem hiding this comment.
@PureWeen not sure if we still need those methods here...
|
Re-closing this one again unfortunately :-/ I've been chatting with @pictos a bit of how to bring this behavior to XCT |
|
will it be available in XCT? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds support for users passes complex data in Shell navigation with the new object
ShellParameter.Issues Resolved
API Changes
Added:
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
When you navigate with Shell you can pass
ShellParameterin the method, just like:await Shell.Current.GoToAsync("//myAwesomeUri", new Dictionary { {"My key", someObj} });PR Checklist