This repository has been archived by the owner on May 1, 2024. It is now read-only.
Check TargetPlatformIdentifier for UAP #12611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
added
the
blocker
Redth
approved these changes
Oct 27, 2020
jsuarezruiz
approved these changes
Oct 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
VS 16.8 now sets TargetPlatformMinVersion to
7.0on the shared project which is causing the UWP specific target to run and give a bogus warning messageThis PR checks that the TargetPlatformIdentifier matches UAP so it only runs for UAP projects
This PR also updates the Target and Min Target to match WinUI 2.4 suggestions
Issues Resolved
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1237998
Platforms Affected
Testing Procedure
PR Checklist