This repository has been archived by the owner on May 1, 2024. It is now read-only.
Restore ability to display header, footer, and empty view simultaneously #13247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
added
p/iOS 🍎
i/regression
blocker
PureWeen
suggested changes
Dec 29, 2020
There was a problem hiding this comment.
- If you set the drop down to RTL before triggering the Empty View then the text is flipped
- Open Empty View RTL Gallery
- Set Drop down to RTL
- Enter in a filter that causes empty view to show
- Text is flipped horizontally
- The footer view renderers differently on iOS vs Android ([Bug] CollectionView Footer rendering different on android vs iOS #13252)
Now passes test from issue 8326
hartez
force-pushed
the
double-emptyview
branch
from
7b26ef0
to
f13cd83
Compare
PureWeen
approved these changes
Dec 30, 2020
|
iOS 13 test failure is not related to these changes. |
rmarinho
approved these changes
Dec 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Somewhere along the way the CollectionView's EmptyView on iOS regressed and no longer could display the header, footer, and EmptyView at the same time (the EmptyView would sit on top of the header, obscuring it).
These changes undo the changes which caused the regression and fix the problem a different way, leaving the EmptyView and Header intact.
No automated test for the regression here, because it's already included in #13032.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Control Gallery -> Issue 8326; the header, footer, and empty view should all be visible when the test loads.
Control Gallery -> CollectionView Gallery -> EmptyView Gallery -> EmptyView RTL; the empty view text should only shift alignment when the page is set to RTL, rather than horizontally flipping the text (see #12892).
PR Checklist