Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Force Shell TitleView to height of container and fix flyout header scroll behaviors #13514

Merged
merged 8 commits into from Feb 8, 2021
Merged

Force Shell TitleView to height of container and fix flyout header scroll behaviors #13514

merged 8 commits into from Feb 8, 2021

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Jan 23, 2021 •
edited

Description of Change

Fixed the TitleView on Shell to force its bounds to the size of the titleview container on iOS. It's currently using the measured height of View to layout. Also fixed the scroll behaviors on the shell flyout. The TitleView and the FlyoutHeader both use the same control helpers to renderer so the fix applied both places

Issues Resolved

Platforms Affected

  • iOS

Testing Procedure

  • UI Tests included
  • Test the Flyout Header and the Shell Title View to verify that they work correctly

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Jan 23, 2021
@PureWeen PureWeen added this to To do in vNext+1 (5.0.0) via automation Jan 23, 2021
@PureWeen PureWeen added this to the 5.0.0 milestone Jan 23, 2021
@PureWeen PureWeen moved this from To do to In Review in vNext+1 (5.0.0) Jan 23, 2021
@PureWeen PureWeen added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Jan 23, 2021
@PureWeen PureWeen changed the title Force Shell TitleView to height of container Force Shell TitleView to height of container and fix flyout header scroll behaviors Jan 23, 2021
@PureWeen PureWeen removed the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Jan 23, 2021
@rachelkang rachelkang mentioned this pull request Feb 1, 2021
Closed
@hartez hartez added this to To Fix in 5.0.0 SR 3 via automation Feb 2, 2021
@hartez hartez removed this from In Review in vNext+1 (5.0.0) Feb 2, 2021
@hartez hartez moved this from To Fix to PR Needs Review in 5.0.0 SR 3 Feb 2, 2021
@hartez hartez moved this from PR Needs Review to PR Build/Test Failures in 5.0.0 SR 3 Feb 2, 2021
@PureWeen
Copy link
Contributor Author

PureWeen commented Feb 4, 2021

Failing tests not related

@PureWeen PureWeen moved this from PR Build/Test Failures to PR Needs Review in 5.0.0 SR 3 Feb 4, 2021
@PureWeen PureWeen mentioned this pull request Feb 4, 2021
Merged
2 tasks
rmarinho
rmarinho reviewed Feb 5, 2021
View reviewed changes
Xamarin.Forms.Platform.iOS/Renderers/ShellPageRendererTracker.cs Outdated
@@ -415,6 +416,20 @@ public override CGRect Frame
}
}

public override void WillMoveToSuperview(UIView newsuper)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newSuper ?

rmarinho
rmarinho approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

rachelkang
rachelkang approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All UI Tests passing on Android and iOS, and nuget fixes all issues mentioned

iOS different behavior of flyout scrollview will need to be further explored in a separate issue/PR

@PureWeen PureWeen merged commit 0e708d0 into 5.0.0 Feb 8, 2021
5.0.0 SR 3 automation moved this from PR Needs Review to Done Feb 8, 2021
@PureWeen PureWeen deleted the fix_13476 branch February 8, 2021 22:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@rachelkang rachelkang rachelkang approved these changes

Assignees
No one assigned
Labels
5.0.0 Regression on 5.0.0 a/grid a/shell 🐚 a/titleview blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. p/Android p/iOS 🍎 t/bug 🐛
Projects
No open projects
5.0.0 SR 3
Done
Milestone
5.0.0
4 participants
@PureWeen @rmarinho @rachelkang @samhouts