Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix Search Handler results to measure to the provided content #13658

Merged
merged 10 commits into from
Feb 9, 2021
Merged

Fix Search Handler results to measure to the provided content #13658

merged 10 commits into from
Feb 9, 2021

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Feb 4, 2021 •
edited
Loading

THIS PR IS BASED ON TOP OF
#13514

Description of Change

The ContentView used to render the results of a search is used in a number of scenarios (flyout items, footer, flyout content) . These changes made it so the ContentView always sizes to the passed in height but with Search results we just want the ContentView to measure to the height of the content.

Issues Resolved

API Changes

In order to make the SearchHandler testable I needed to add an Automation property

Added:

  • string SearchHandler.AutomationId { get; set; } //Bindable Property

Platforms Affected

  • Core/XAML (all platforms)
  • iOS
  • Android

Testing Procedure

  • test the produced nuget inside Xaminals to validate that it's correctly working
  • UI Test has also been included

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added this to To Fix in 5.0.0 SR 3 via automation Feb 4, 2021
@PureWeen PureWeen changed the title Fix 13403 Fix Search Handler results to measure to the provided content Feb 4, 2021
@PureWeen PureWeen removed the request for review from StephaneDelcroix February 4, 2021 21:54
@PureWeen PureWeen moved this from To Fix to PR Needs Review in 5.0.0 SR 3 Feb 4, 2021
@PureWeen PureWeen mentioned this pull request Feb 5, 2021
Closed
@rachelkang rachelkang mentioned this pull request Feb 8, 2021
Closed
jsuarezruiz
jsuarezruiz approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captura de pantalla 2021-02-09 a las 14 26 51

Xamarin.Forms.Platform.iOS/Renderers/ShellPageRendererTracker.cs Show resolved Hide resolved
@rmarinho rmarinho merged commit af9ad3c into 5.0.0 Feb 9, 2021
5.0.0 SR 3 automation moved this from PR Needs Review to Done Feb 9, 2021
@rmarinho rmarinho deleted the fix_13403 branch February 9, 2021 14:46
@samhouts samhouts added this to the 5.0.0 milestone Feb 12, 2021
@samhouts samhouts added 5.0.0 Regression on 5.0.0 i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often labels Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

Assignees
No one assigned
Labels
5.0.0 Regression on 5.0.0 a/shell 🐚 i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often i/regression p/Android p/iOS 🍎 t/bug 🐛
Projects
No open projects
5.0.0 SR 3
Done
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

[Bug] Shell.SearchHandler shows items with full screen height on Android
4 participants
@PureWeen @rmarinho @jsuarezruiz @samhouts