Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[macOS] Update Switch renderer #14334

Merged
merged 3 commits into from
Jul 7, 2021
Merged

[macOS] Update Switch renderer #14334

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
463e128
[macOS] Update Switch renderer #14313
mhrastegari Jun 8, 2021
17147e4
[macOS] Update Switch renderer #14313
mhrastegari Jun 8, 2021
329dc0c
Merge branch 'MHRastegari/switch-macos' of https://github.com/mhraste…
mhrastegari Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 4 additions & 7 deletions Xamarin.Forms.Platform.MacOS/Renderers/SwitchRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace Xamarin.Forms.Platform.MacOS
{
public class SwitchRenderer : ViewRenderer<Switch, NSButton>
public class SwitchRenderer : ViewRenderer<Switch, NSSwitch>
{
bool _disposed;

Expand All @@ -18,12 +18,9 @@ protected override void OnElementChanged(ElementChangedEventArgs<Switch> e)
{
if (Control == null)
{
SetNativeControl(new NSButton { AllowsMixedState = false, Title = string.Empty });

Control.SetButtonType(NSButtonType.Switch);
SetNativeControl(new NSSwitch());
Control.Activated += OnControlActivated;
}

UpdateState();
e.NewElement.Toggled += OnElementToggled;
}
Expand All @@ -45,7 +42,7 @@ protected override void Dispose(bool disposing)

void OnControlActivated(object sender, EventArgs e)
{
ElementController?.SetValueFromRenderer(Switch.IsToggledProperty, Control.State == NSCellStateValue.On);
ElementController?.SetValueFromRenderer(Switch.IsToggledProperty, Control.State == (int)NSCellStateValue.On);
}

void OnElementToggled(object sender, EventArgs e)
Expand All @@ -55,7 +52,7 @@ void OnElementToggled(object sender, EventArgs e)

void UpdateState()
{
Control.State = Element.IsToggled ? NSCellStateValue.On : NSCellStateValue.Off;
Control.State = Element.IsToggled ? (int)NSCellStateValue.On : (int)NSCellStateValue.Off;
}
}
}