This repository has been archived by the owner on May 1, 2024. It is now read-only.
Refactor Entry ClearButton observer lifecycle to prevent NRE on older iOS versions #14828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rotorgames could you please test if your fix is still intact like this? @lee-m, would you be able to grab the NuGet as described here and let us know if this fixes this issue? That will greatly speed up the review process. Besides verifying if this particular issue is fixed also be sure to check other scenarios in the same area to make sure that this fix doesn't accidentally has side-effects 🙂 Thanks! |
|
@jfversluis Certainly. I'll let you know how I get on. |
|
@jfversluis I'm not seeing the crash anymore using the preview NuGet package for this PR. |
|
Perfect, thank you so much for testing this! @rotorgames I would really appreciate your feedback on this as well :) |
2 tasks
jsuarezruiz
approved these changes
Nov 5, 2021
jfversluis
added a commit
that referenced
this pull request
Nov 9, 2021
This reverts commit f95f671.
2 tasks
jfversluis
added a commit
that referenced
this pull request
Nov 10, 2021
jfversluis
added a commit
that referenced
this pull request
Nov 16, 2021
This reverts commit f95f671.
jfversluis
added a commit
that referenced
this pull request
Nov 16, 2021
* Revert "Fix hangs and NREs with Entry Observer (#14859)" This reverts commit 5188c4f. * Revert "Refactor observer lifecycle (#14828)" This reverts commit f95f671. * Revert "Fix crashing on iOS < 14 if ClearButtonVisibility = WhileEditing in Entry (#14479 #14510) (#14526)" This reverts commit a21b36a.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
No more crash on older iOS versions
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist