Fix hangs and NREs with Entry Observer #14859
Conversation
This reverts commit f95f671.
Co-Authored-By: Javier Suárez <javiersuarezruiz@hotmail.com>
|
@jfversluis Does Javier's change actually fix the issue? In #14790 you commented
Where the "other fix" is the change that has now been reverted in favour of those in #14790. What is a huge concern for me is the severity of this (bit of a showstopper for us) and that the description of why the crash occurs does not match what I'm seeing with my own code. It'd be a real pain to have to wait a month for SR8 for any follow on fixes for this. |
|
@lee-m you're welcome to try out version 5.0.0.7816 on the PR feed and let me know :) My fix was causing crashes/hangs in other areas, so clearly that wasn't the way as well |
|
@jfversluis I'll happily test out the PR NuGet but I won't be in a position to do this until tomorrow, unfortunately. Hopefully everything still works :) |
|
No rush! Let me know how it goes! This one, among others, I have found a couple of things to iron out before creating the actual release. It will probably be early next week. |
|
@jfversluis Using 5.0.0.7816 on the PR feed also fixes the crash I'm seeing. I've still got no idea how given the explanation but it does so I must be missing something :) Looking forward to getting my hands on this in SR7! |
|
YES! That is great news. Thanks for working together on this @lee-m Be on the lookout for the new release! |
This reverts commit 5188c4f.
* Revert "Fix hangs and NREs with Entry Observer (#14859)" This reverts commit 5188c4f. * Revert "Refactor observer lifecycle (#14828)" This reverts commit f95f671. * Revert "Fix crashing on iOS < 14 if ClearButtonVisibility = WhileEditing in Entry (#14479 #14510) (#14526)" This reverts commit a21b36a.
Description of Change
The fix in #14828 caused, again, issues unfortunately. I have now taken the changes from Javier in #14790 which do seem to work better. Reverted the one commit and added Javiers fix.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist