This repository has been archived by the owner on May 1, 2024. It is now read-only.
Port CollectionView performance fixes from .NET MAUI #15697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -240,7 +240,7 @@ public static void SetInheritedBindingContext(BindableObject bindable, object va | |||
| } | |||
| else | |||
| { | |||
| bindable._inheritedContext = value; | |||
| bindable._inheritedContext = new WeakReference(value); | |||
There was a problem hiding this comment.
As a UNO instead of creating a new WeakReference instance, you can use code like this to reduce GC pressure:
Suggested change
| bindable._inheritedContext = new WeakReference(value); | |
| bindable._inheritedContext ??= new WeakReference(null); | |
| bindable._inheritedContext.Target = value; |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Port CollectionView performance fixes from .NET MAUI dotnet/maui#13327 from Peppers.
The types of leaks this fixes:
ViewModelsCollectionView,ListView, etc. with data-bindings.VieworPagethat is now removed from the screen via navigation, de-parenting, etc.API Changes
None
Platforms Affected
PR Checklist