This repository has been archived by the owner on May 1, 2024. It is now read-only.
UWP Dispatcher should use the internal core dispatcher for state #15716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
force-pushed
the
dev/mattleibow/fix-dispatcher
branch
from
b56ff28
to
76bf988
Compare
mattleibow
commented
Apr 6, 2023
| bool IDispatcher.IsInvokeRequired => Device.IsInvokeRequired; | ||
| bool IDispatcher.IsInvokeRequired => !_coreDispatcher.HasThreadAccess; |
There was a problem hiding this comment.
This is the main fix to use the correct core dispatcher. The Device.IsInvokeRequired implementation only verifies against the main/first dispatcher.
Comment on lines
+30
to
+34
| else | ||
| { | ||
| s_current = new Dispatcher(); | ||
| return s_current; | ||
| } |
There was a problem hiding this comment.
This is to fix the scenario where you try and get the dispatcher before the renderer is created, so we fall back to the window's dispatcher. This is because the dispatcher is cached and if there is no renderer, the FallbackDispatcher is used - and that is always using the first/main thread via the Device.
jfversluis
approved these changes
Apr 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR makes sure the UWP dispatcher is using the internal core dispatcher for thread access checks instead of the global device dispatcher which does not support multiple windows.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist