New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Don't force the SetSingleLine() to true #234

Merged
merged 1 commit into from Aug 2, 2016

Conversation

Projects
None yet
4 participants
@Depechie
Contributor

Depechie commented Jun 21, 2016

Description of Change

When using the SetSingleLine(true) in the base LabelRenderer on Android, developers won't be able to use the SetMaxLines() in their own Custom Renderers
later on.
So we force a single line by using the SetMaxLines(1) in the
base LabelRenderer and SetSingleLine(false)

[Android] By using the SetSingleLine(true), the developers are no
longer able to use the SetMaxLines() in their own Custom Renderers
later on. So we force a single line by using the SetMaxLines(1) in the
base LabelRenderer and SetSingleLine(false)
@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Jun 21, 2016

Hi @Depechie, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

dnfclas commented Jun 21, 2016

Hi @Depechie, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@Depechie Depechie changed the title from [Android] Don't force the SetSingleLinet to true to [Android] Don't force the SetSingleLine() to true Jun 21, 2016

@jassmith

This comment has been minimized.

Show comment
Hide comment
@jassmith

jassmith Jul 18, 2016

Member

Needs manual testing to verify this doesn't screw with truncation.

Member

jassmith commented Jul 18, 2016

Needs manual testing to verify this doesn't screw with truncation.

@jassmith jassmith merged commit bfeffa7 into xamarin:master Aug 2, 2016

1 check failed

iOS7-UITests Finished TeamCity Build Xamarin.Forms :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS7 : Tests failed: 1, passed: 336, ignored…
Details

@samhouts samhouts added this to the 2.3.2 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment