This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android] Don't force the SetSingleLine() to true #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longer able to use the SetMaxLines() in their own Custom Renderers later on. So we force a single line by using the SetMaxLines(1) in the base LabelRenderer and SetSingleLine(false)
|
Hi @Depechie, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
Depechie
changed the title
|
Needs manual testing to verify this doesn't screw with truncation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When using the SetSingleLine(true) in the base LabelRenderer on Android, developers won't be able to use the SetMaxLines() in their own Custom Renderers
later on.
So we force a single line by using the SetMaxLines(1) in the
base LabelRenderer and SetSingleLine(false)