This repository has been archived by the owner on May 1, 2024. It is now read-only.
[8.1/UWP] ListView allows selection with enter key #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 with passing UI tests |
| @@ -521,6 +526,12 @@ void OnListItemClicked(int index) | |||
| #endif | |||
| } | |||
|
|
|||
| void OnEnterKeyPressed(object sender, KeyRoutedEventArgs e) | |||
pauldipietro
force-pushed
the
fix-bugzilla42188
branch
from
4bbee6a
to
fef5a36
Compare
4 tasks
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Putting ListView in line with standard behavior where
ItemClickwould normally fire off when pressing the enter key to select a ListView item.Bugs Fixed
https://bugzilla.xamarin.com/show_bug.cgi?id=42188
API Changes
None
Behavioral Changes
If a user had a custom renderer with behavior linked to
KeyUpfor the enter key, something unintentional could potentially occur, though perhaps unlikely.PR Checklist