This repository has been archived by the owner on May 1, 2024. It is now read-only.
Prevent FormsAppCompatActivity from loading fragments we don't use on restart #246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Prevent the
FormsAppCompatActivity
from attempting to restore fragments when being restored after being killed because of limited memory. Previously, the fragments were restored and then ignored by XF; in the case of nested fragments (e.g., aTabbedPage
orMasterDetailPage
containing anotherTabbedPage
), this caused anIllegalStateException
(followed by a crash) because a view could not be associated with the nested fragment. Now theFormsAppCompatActivity
won't attempt to restore the fragments we weren't going to use anyway. (Bonus: slight memory improvement!)Bugs Fixed
API Changes
None
Behavioral Changes
If a user is deliberately matching up and restoring fragments by tag when the application is restored, that user will have to derive from FormsAppCompatActivity and override the
AllowFragmentRestore
property to returntrue
.PR Checklist
… restart