Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[UWP] NRE when checking IsInNativeLayout during OnScrollToRequested #2620

Merged
merged 1 commit into from May 11, 2018
Merged

[UWP] NRE when checking IsInNativeLayout during OnScrollToRequested #2620

merged 1 commit into from May 11, 2018

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented May 7, 2018 •
edited by samhouts

Description of Change

  • Added null check on ScrollView Element in UWP Scroll View Renderer
  • unsubscribe from ScrollToRequested in dispose to improve cleanup

Bugs Fixed

fixes #2336

API Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@samhouts samhouts added this to In Review in v3.6.0 May 7, 2018
@xamarin-release-manager xamarin-release-manager added the API-change Heads-up to reviewers that this PR may contain an API change label May 7, 2018
@PureWeen PureWeen merged commit 7e563b0 into master May 11, 2018
v3.6.0 automation moved this from In Review to Done May 11, 2018
@PureWeen PureWeen deleted the gh2336 branch May 11, 2018 19:13
@samhouts samhouts added this to the 3.2.0 milestone Jun 26, 2018
@samhouts samhouts removed this from Done in v3.6.0 Jun 26, 2018
@samhouts samhouts added this to Done in v3.2.0 Jun 26, 2018
@samhouts samhouts modified the milestone: 3.2.0 Sep 12, 2018
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Sep 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@samhouts samhouts samhouts approved these changes

@pauldipietro pauldipietro Awaiting requested review from pauldipietro

Assignees
No one assigned
Labels
API-change Heads-up to reviewers that this PR may contain an API change approved Has two approvals, no pending reviews, and no changes requested p/UWP t/bug 🐛
Projects
No open projects
v3.2.0
  
Done
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

[UWP] NRE when checking IsInNativeLayout during OnScrollToRequested
4 participants
@PureWeen @rmarinho @samhouts @xamarin-release-manager