This repository has been archived by the owner on May 1, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Changes the Windows Phone RT platform resource lookup to get Setters from ancestor Styles in addition to the defined style.
Tests omitted because, as far as I can tell, testing the PlatformResourceProviders isn't possible.
Bugs Fixed
BodyStyle
, which maps to the nativeBodyTextBlockStyle
, which only directly defines a newTextBlock.LineHeight
value. As Xamarin's style translation ignores that particular property, any Label using the XamarinBodyStyle
would get an unstyled Label, when they should, at the very least, receive the styling from the nativeBaseTextBlockStyle
.API Changes
None.
Behavioral Changes
There should be no visible changes yet. The only two Device Styles that render correctly on Windows Phone 8.1 RT, TitleStyle and SubtitleStyle do not have any elements inherited from their BasedOn Styles that a Xamarin Style uses. However, if 43783 were to be fixed without also fixing this, the styles would be incomplete.
Recommend do not merge until 43783 is fixed.
PR Checklist