Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Windows] Fix Device Style inheritance #324
Description of Change
Changes the Windows Phone RT platform resource lookup to get Setters from ancestor Styles in addition to the defined style.
Tests omitted because, as far as I can tell, testing the PlatformResourceProviders isn't possible.
There should be no visible changes yet. The only two Device Styles that render correctly on Windows Phone 8.1 RT, TitleStyle and SubtitleStyle do not have any elements inherited from their BasedOn Styles that a Xamarin Style uses. However, if 43783 were to be fixed without also fixing this, the styles would be incomplete.
Recommend do not merge until 43783 is fixed.
Hi @pingzing, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!