Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[XamlC] Throws on duplicate x:Key #3542

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Conversation

StephaneDelcroix
Copy link
Member

@StephaneDelcroix StephaneDelcroix commented Aug 10, 2018

Description of Change

Throws a XamlParseException on duplicate x:Key on RDs. This will find
duplicate in xaml, but duplicates can still happen if the RD is modified
in code. Those dupes are already detected at runtime.

Issues Resolved

API Changes

/

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

/

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

Throws a XamlParseException on duplicate x:Key on RDs. This will find
duplicate in xaml, but duplicates can still happen if the RD is modified
in code. Those dupes are already detectd at runtime.

- helps, but doesn't fixes, #3512
@StephaneDelcroix StephaneDelcroix merged commit 088d369 into 3.2.0 Aug 14, 2018
@StephaneDelcroix StephaneDelcroix deleted the Xamlc_duplicateKey branch August 14, 2018 08:14
@samhouts samhouts added this to the 3.2.0 milestone Sep 11, 2018
@samhouts samhouts modified the milestone: 3.2.0 Sep 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants