This repository has been archived by the owner on May 1, 2024. It is now read-only.
Fix several Android memory leaks #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
approved these changes
Sep 15, 2016
| if (disposing && !_disposed) { | ||
| _disposed = true; | ||
| if (_disposed) | ||
| { |
| if (mapModel != null) { | ||
| MessagingCenter.Unsubscribe<Map, MapSpan> (this, MoveMessageName); | ||
| ((ObservableCollection<Pin>)mapModel.Pins).CollectionChanged -= OnCollectionChanged; | ||
| if (disposing) |
There was a problem hiding this comment.
Can't return right here, still need to call base.Dispose(disposing).
| } | ||
| // We do *not* eagerly dispose of the _pageContainer here; doing so causes a memory leak | ||
| // if animated fragment transitions are enabled (it removes some info that the animation's | ||
| // onAnimationEnd handler requires to properly clean things up) |
| { | ||
| tcs.TrySetResult(true); | ||
| fragment.UserVisibleHint = true; | ||
| fragment.UserVisibleHint = !removed; |
There was a problem hiding this comment.
where does remove get set? after animation ?
There was a problem hiding this comment.
It's one of the parameters to SwitchContentAsync (the method we're in right now).
StephaneDelcroix
approved these changes
Sep 16, 2016
| NativeMap.MyLocationEnabled = false; | ||
| NativeMap.SetOnCameraChangeListener(null); | ||
| NativeMap.InfoWindowClick -= MapOnMarkerClick; | ||
| NativeMap.Dispose(); | ||
| } |
There was a problem hiding this comment.
NativeMap refers to MapView.Map, which is read-only.
| Control.RemoveOnAttachStateChangeListener(this); | ||
| Control.Tag = null; | ||
| _textColorSwitcher = null; | ||
| } |
There was a problem hiding this comment.
Not here. The base class ViewRenderer<TView, TNativeView> still has some cleanup to do on Control, then it gets set to null.
campersau
reviewed
Sep 16, 2016
| ((ObservableCollection<Pin>)mapModel.Pins).CollectionChanged -= OnCollectionChanged; | ||
| if (disposing) | ||
| { | ||
| _disposed = true; |
There was a problem hiding this comment.
Not needed. This is already done above.
|
Needs rebase |
Clean up OnFocusChangeListener on ViewRenderer during disposal Prevent memory leak of PageContainer/FragmentContainer when animating fragment transitions Call Destroy() on Map during disposal Rebasing
hartez
force-pushed
the
fix-bugzilla39489-part2
branch
from
18d418c
to
0047e9f
Compare
samhouts
approved these changes
Sep 26, 2016
4 tasks
Merged
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes for several memory leaks on Android. Changes include:
Bugs Fixed
API Changes
None
Behavioral Changes
None
PR Checklist