This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] More button on TabbedPage should work #440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test merge
|
@jassmith do you remember more things about this? I don't i could try look up the history. |
|
The issue is that the more button will implicitly wrap the child tab into a UINavigationController. Unfortunately a NavigationPage is also a UINavigationController. This means if your "more" tabs are also NavigationPages you will get a double UINavigationController and this will look wholly wrong. It "works" with ContentPages, unfortunately we expose no mechanism for the user to resolve this issue, so we have disabled it. I proper fix requires a hijacking of the More controller to make its navigation page match the child NavigationPage properties. |
4 tasks
mattleibow
pushed a commit
that referenced
this pull request
Jan 28, 2021
* GH-440 Map location fix on iOS (#441) * Implemented maps as mentioned in branch name issue. also fixed a spelling mistake * Finished reset of fork * Fixed ios maps transportation mode * Add documentation and implement navigation modes on UWP. * Implement Android navigation options. Also add bicycle into the mix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
iOS
TabbedPageshowsMorebutton when tab items can't fit on screen, but tapping on this button sends you to the first tab. This PR fixes the issue. Note that theEditbutton is missing, and this is XF change. See #398. In my opinion, this button should be enabled and we should find out what kind of error it causes with aNavigationPage. I don't believe a feature should be hidden to hide a bug. When I testedEdit, it worked fine though I don't think I tested it with aNavigationPage.Bugs Fixed
PR Checklist