Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Ignore null context change on UAP #4412

Merged
merged 1 commit into from Dec 4, 2018
Merged

Ignore null context change on UAP #4412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions Xamarin.Forms.Platform.UAP/CellControl.cs
View file
Open in desktop
Expand Up @@ -161,6 +161,9 @@ void OnContextActionsChanged(object sender, NotifyCollectionChangedEventArgs e)

void OnDataContextChanged(FrameworkElement sender, DataContextChangedEventArgs args)
{
if (args.NewValue == null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe below delete the check args.NewValue != null?

return;

// We don't want to set the Cell until the ListView is realized, just in case the
// Cell has an ItemTemplate. Instead, we'll store the new data item, and it will be
// set on MeasureOverrideDelegate. However, if the parent is a TableView, we'll already
Expand Down